Skip to content

Conversation

paulb777
Copy link
Member

Fix #10186

Do separate Carthage build for GoogleUtilities instead of FirebaseCoreDiagnostics to enable Platform Logging distinction between Carthage and zip.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM. I downloaded the zip and will verify it works as expected.

@paulb777 paulb777 merged commit 747eac2 into master Sep 23, 2022
@paulb777 paulb777 deleted the pb-carthage-googutil branch September 23, 2022 14:12
ncooke3 added a commit that referenced this pull request Sep 24, 2022
* [Firebase 10] Bump 9.X versions to 10.0.0

* Bump min. GTMSessionFetcher dep version to 2.1

* Bump min. GDT dep version to 9.2

* Bump min. GULs dep version to 7.8

* Fix unintentional nanopb replace

* Fix unintentional nanopb replace (2)

* Fix unintentional nanopb replace (3)

* Fix unintentional nanopb replace (4)

* Fix unintentional nanopb replace (4)

* Trigger all CI

* Bump FirebaseCombineSwift to 10

* Fix FirebaseStorage.podspec
I'm not sure what happened here. I had committed it during the rebase but guess not?

* Fix unintentional nanopb replace (5)

* Disable two tests to unblock staging

* Fix and re-enable FIROptions tests

* Update deployment targets in Firebase.podspec

* Add CHANGELOG entry for GTMSessionFetcher

* Fix AppCheck iOS availability

* Fix inadvertent API change (#10245)

* Docs update for Extensions and putFile (#10248)

* App google domain support (#10249)

Adding new 1p domain "app.google" support in FDL SDK.

* Remote Config Dynamic Property Wrapper (#10155)

* Separate GoogleUtilities Carthage build (#10250)

* Public count (#10246)

* Public Count

* Swift Test Commit

* Swift Format

* No extra whitespace

* Hopefully formatted.

* Change log and feedback.

* Revert "Public count (#10246)" (#10252)

This reverts commit 8aae6be.

* Make Firestore use FirebaseDataEncoder and FirebaseDataDecoder (re-implementation of #8858) (#9465)

* Bump tvOS minimum support version to 12.0

* [skip ci] Revert Gemfile

Co-authored-by: Paul Beusterien <[email protected]>
Co-authored-by: Eldhose M Babu <[email protected]>
Co-authored-by: Charlotte Liang <[email protected]>
Co-authored-by: wu-hui <[email protected]>
Co-authored-by: Morten Bek Ditlevsen <[email protected]>
@firebase firebase locked and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Firebase 10] Placeholder for addressing distribution macros (e.g. FIREBASE_BUILD_CARTHAGE)
3 participants