Skip to content

revert rtdb DataSnapshot.exists() behavior to match lodash.isNull #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

revert rtdb DataSnapshot.exists() behavior to match lodash.isNull #1420

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5a6efb
revert rtdb DataSnapshot.exists() behavior to match lodash.isNull
Berlioz Jun 9, 2023
fb125e6
fix lint
Berlioz Jun 9, 2023
03a494d
Merge branch 'master' into vf_rtdb_zero_values_exist
Berlioz Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions src/common/providers/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,20 +152,12 @@ export class DataSnapshot implements database.DataSnapshot {
}

/**
* Returns `true` if this `DataSnapshot` contains any data. It is slightly more
* efficient than using `snapshot.val() !== null`.
* Returns `true` if this `DataSnapshot` contains any data.
*
* @return `true` if this `DataSnapshot` contains any data; otherwise, `false`.
*/
exists(): boolean {
const val = this.val();
if (!val || val === null) {
return false;
}
if (typeof val === "object" && Object.keys(val).length === 0) {
return false;
}
return true;
return this.val() !== null;
}

/**
Expand Down