Add >=jest@28 as a peerDep #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a peerDep of >=jest@28. jest@28 includes jestjs/jest#11961, which supports `exports` in `package.json`. Without this, jest users that use jest@27 or below will throw an error when firebase-functions-test attempts to import several named exports. Fixes #151
The original motivation to upgrade was to resolve the breaking change mentioned [here](DefinitelyTyped/DefinitelyTyped#60310) I chose this version to maintain parity with firebase-functions [here](https://github.com/firebase/firebase-functions/blob/master/package.json#L224)
This commit continues the chain of upgrading stale dependencies due to a fun cascading effect of adding a peerDep. If you give a moose a muffin...
colerogers
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit adds a peerDep of >=jest@28 and [email protected].
jest@28 includes jestjs/jest#11961, which
supports
exportsinpackage.json.Without this, jest users that use jest@27 or below will throw an error
when firebase-functions-test attempts to import several named exports.
Fixes #151