Skip to content

fix: Badly formatted log messages in private/util.py #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 10, 2023
Merged

fix: Badly formatted log messages in private/util.py #140

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a26db22
fix the most egregious issue with the use of python logging
ekalosak Sep 16, 2023
08e8707
fixed all occurrences in private/utils.py
ekalosak Sep 26, 2023
0917241
Merge branch 'main' into fix/logging-private-util
ekalosak Sep 26, 2023
deed952
Merge branch 'main' into fix/logging-private-util
ekalosak Oct 5, 2023
bd1aa2b
Merge branch 'main' into fix/logging-private-util
taeold Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/firebase_functions/private/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def _on_call_valid_body(request: _Request) -> bool:
}
if len(extra_keys) != 0:
_logging.warning(
"Request body has extra fields: ",
"Request body has extra fields: %s",
"".join(f"{key}: {value}," for (key, value) in extra_keys.items()),
)
return False
Expand Down Expand Up @@ -156,7 +156,7 @@ def _on_call_valid_content_type(request: _Request) -> bool:

# Check that the Content-Type is JSON.
if content_type.lower() != "application/json":
_logging.warning("Request has incorrect Content-Type.", content_type)
_logging.warning("Request has incorrect Content-Type: %s", content_type)
return False

return True
Expand Down Expand Up @@ -273,7 +273,7 @@ def on_call_check_tokens(request: _Request,) -> _OnCallTokenVerification:
errs.append(("Auth token was rejected.", log_payload))

if len(errs) == 0:
_logging.info("Callable request verification passed", log_payload)
_logging.info("Callable request verification passed: %s", log_payload)
else:
_logging.warning(f"Callable request verification failed: ${errs}",
log_payload)
Expand Down