Skip to content

fix: issue with logging #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 14, 2023
Merged

fix: issue with logging #134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2ea9f6
logging.warning doesn't allow null positional (nor keyword) args
ekalosak Sep 11, 2023
d2655d6
clarified logic around another potential None arg in a logging call
ekalosak Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/firebase_functions/private/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def _on_call_valid_body(request: _Request) -> bool:
return False

# The body must have data.
if request.json is None or "data" not in request.json:
if "data" not in request.json:
_logging.warning("Request body is missing data.", request.json)
return False

Expand Down Expand Up @@ -143,7 +143,7 @@ def _on_call_valid_content_type(request: _Request) -> bool:
content_type: str | None = request.headers.get("Content-Type")

if content_type is None:
_logging.warning("Request is missing Content-Type.", content_type)
_logging.warning("Request is missing Content-Type.")
return False

# If it has a charset, just ignore it for now.
Expand Down