Skip to content

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 7, 2022

LevelDb version 1.23 is the first LevelDb release to include the pinned commit, google/leveldb@e0d5f83.

LevelDb version 1.23 is the first LevelDb release to include the pinned commit, google/leveldb@e0d5f83.
@dconeybe dconeybe self-assigned this Apr 7, 2022
@@ -567,6 +567,11 @@ workflow use only during the development of your app, not for publicly shipping
code.

## Release Notes
### Upcoming Release
- Changes
- Firestore/Database (desktop): Upgrade LevelDb dependency to 1.23
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we usually capitalize Desktop here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@jonsimantov jonsimantov self-requested a review April 8, 2022 15:50
@dconeybe dconeybe merged commit 8e37ccc into main Apr 8, 2022
@dconeybe dconeybe deleted the dconeybe/LevelDbUpgrade_1_23 branch April 8, 2022 17:11
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

✅  Integration test succeeded!

Requested by @dconeybe on commit 8e37ccc
Last updated: Fri Apr 8 12:46 PDT 2022
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Apr 8, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Apr 8, 2022
@firebase firebase locked and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants