Skip to content

Delete app/src/mutex.h and adjust includes to app/src/include/firebase/internal/mutex.h #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2021
Merged

Delete app/src/mutex.h and adjust includes to app/src/include/firebase/internal/mutex.h #795

merged 2 commits into from
Dec 20, 2021

Conversation

dconeybe
Copy link
Contributor

Delete app/src/mutex.h, which, in #792, was converted to just an empty shell that points to app/src/include/firebase/internal/mutex.h, and adjust all instances where it was included to point to the new location.

This is the third PR (the previous ones being #751 and #792) towards moving firebase::Mutex into the public-internal includes directory, so that it can be used by future.h. See #747 for the rationale.

Googlers can see b/206520921 for more details.

@dconeybe dconeybe self-assigned this Dec 17, 2021
@dconeybe dconeybe added the skip-release-notes Skip release notes check label Dec 17, 2021
@dconeybe dconeybe changed the title Dconeybe/mutex migrate includes to public internal Delete app/src/mutex.h and adjust includes to app/src/include/firebase/internal/mutex.h Dec 17, 2021
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Dec 17, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Dec 17, 2021
@github-actions
Copy link

github-actions bot commented Dec 17, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @dconeybe on commit fdf6ffe
Last updated: Mon Dec 20 13:48 PST 2021
View integration test log & download artifacts

Failures Configs
firestore [TEST] [ERROR] [Android] [ubuntu] [emulator_target]
[TEST] [FLAKINESS] [Android] [ubuntu] [android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation

Add flaky tests to go/fpl-cpp-flake-tracker

dconeybe added a commit that referenced this pull request Dec 17, 2021
@dconeybe
Cherry-pick changes from #795: Delete app/src/mutex.h and adjust incl…
0119402 
…udes to app/src/include/firebase/internal/mutex.h

This commit will be deleted once this is rebased onto main.
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 17, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 17, 2021
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Dec 17, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Dec 17, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 17, 2021
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Dec 17, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Dec 17, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 17, 2021
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Dec 20, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: failed This PR's integration tests failed. labels Dec 20, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 20, 2021
@dconeybe dconeybe requested a review from jonsimantov December 20, 2021 18:39
@dconeybe dconeybe merged commit fdf6ffe into main Dec 20, 2021
@dconeybe dconeybe deleted the dconeybe/MutexMigrateIncludesToPublicInternal branch December 20, 2021 19:19
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Dec 20, 2021
@dconeybe dconeybe mentioned this pull request Dec 20, 2021
Merged
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 20, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 20, 2021
@firebase firebase locked and limited conversation to collaborators Jan 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jonsimantov jonsimantov

@dconeybe dconeybe

Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @jonsimantov