Skip to content

future.h: Fix minor typo in the docs for FutureBase #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2021
Merged

future.h: Fix minor typo in the docs for FutureBase #794

merged 1 commit into from
Dec 16, 2021

Conversation

dconeybe
Copy link
Contributor

No description provided.

@dconeybe dconeybe added the skip-release-notes Skip release notes check label Dec 16, 2021
@dconeybe dconeybe self-assigned this Dec 16, 2021
@dconeybe dconeybe requested a review from jonsimantov December 16, 2021 19:00
@dconeybe dconeybe enabled auto-merge (squash) December 16, 2021 19:13
@dconeybe dconeybe merged commit 30bf73e into main Dec 16, 2021
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 16, 2021
@github-actions
Copy link

github-actions bot commented Dec 16, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @dconeybe on commit 30bf73e
Last updated: Thu Dec 16 14:00 PST 2021
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
firestore [TEST] [FLAKINESS] [Android] [windows] [android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 16, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 16, 2021
@jonsimantov jonsimantov deleted the dconeybe/FutureDocTypoFix branch December 22, 2021 22:38
@firebase firebase locked and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jonsimantov jonsimantov

@dconeybe dconeybe

Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @jonsimantov