Skip to content

Messaging crash during initialization #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Messaging crash during initialization #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d7a7fc
Messaging crash during initialization
TBarendt Nov 25, 2021
d80247a
Update readme
TBarendt Nov 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions messaging/src/android/cpp/messaging.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,8 @@ InitResult Initialize(const ::firebase::App& app, Listener* listener,
pthread_create(&g_poll_thread, nullptr, MessageProcessingThread, nullptr);
FIREBASE_ASSERT(result == 0);

FutureData::Create();

if (g_registration_token_request_state !=
kRegistrationTokenRequestStateNone) {
// Calling this again, now that we're initialized.
Expand All @@ -647,8 +649,6 @@ InitResult Initialize(const ::firebase::App& app, Listener* listener,
kDeliveryMetricsExportToBigQueryEnable);
}

FutureData::Create();

// Supposedly App creation also creates a registration token, but this seems
// to happen before the C++ listeners are able to capture it.
// So this may seem redundant but at least both are respecting the same flag
Expand Down
2 changes: 2 additions & 0 deletions release_build_files/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,6 +578,8 @@ code.
- Messaging (Android): Fixed crash during termination.
([#739](https://github.com/firebase/firebase-cpp-sdk/pull/739))
([#745](https://github.com/firebase/firebase-cpp-sdk/pull/745))
- Messaging (Android): Fixed crash during initialization.
([#760](https://github.com/firebase/firebase-cpp-sdk/pull/760))


### 8.7.0
Expand Down