Skip to content

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 3, 2021

No description provided.

@dconeybe dconeybe added api: firestore no-lint Skip lint checks labels Nov 3, 2021
@dconeybe dconeybe self-assigned this Nov 3, 2021
@google-cla google-cla bot added the cla: yes label Nov 3, 2021
@dconeybe dconeybe requested a review from jonsimantov November 3, 2021 18:11
@dconeybe dconeybe assigned jonsimantov and unassigned dconeybe Nov 3, 2021
@dconeybe dconeybe enabled auto-merge (squash) November 3, 2021 18:11
- Android armeabi libraries must be linked with gcc 4.8.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(is this just a newline?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh yes. It gets added and I keep manually removing it. Maybe it's time to let it win

@dconeybe dconeybe merged commit 91288c8 into main Nov 3, 2021
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Nov 3, 2021
@github-actions
Copy link

github-actions bot commented Nov 3, 2021

⏳  Integration test in progress...

Requested by @dconeybe on commit 91288c8
Last updated: Wed Nov 3 12:13 PDT 2021
View integration test log & download artifacts

@dconeybe dconeybe deleted the dconeybe/FirestoreGAReleaseNotesUpdate branch November 3, 2021 22:35
@var-const
Copy link
Contributor

Congratulations!

@dconeybe
Copy link
Contributor Author

Thanks @var-const! The success was due in no small part to your contributions. Hope all is well :)

@firebase firebase locked and limited conversation to collaborators Dec 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: firestore cla: yes no-lint Skip lint checks tests: in-progress This PR's integration tests are in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants