Skip to content

Update README to suggest Python3 versions #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Update README to suggest Python3 versions #702

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88b0441
Update README to suggest Python3 versions
crwilcox Oct 7, 2021
e94a6e8
Increase minimum recommended python version to match CI
crwilcox Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ The following prerequisites are required for all platforms. Be sure to add any
directories to your PATH as needed.

- [CMake](https://cmake.org/), version 3.1, or newer
- [Python2](https://www.python.com/), version of 2.7, or newer
- [Python](https://www.python.com/), version of 3.6, or newer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested on Python 3.6? As you noted, CI uses Python 3.7, so it might be better to require that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was building using my default (3.10), but moving to 3.7, matching CI, makes sense.

Also, 3.6 is out of support EoY (soon)

- [Abseil-py](https://github.com/abseil/abseil-py)

Note: Once python is installed you can use the following commands to install
Expand Down Expand Up @@ -97,7 +97,7 @@ Home brew can be used to install required dependencies:
# https://github.com/protocolbuffers/protobuf/blob/master/kokoro/macos/prepare_build_macos_rc#L20
ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
source $HOME/.rvm/scripts/rvm
brew install cmake protobuf python2
brew install cmake protobuf python3
sudo chown -R $(whoami) /usr/local
```

Expand Down