Skip to content

updating android and ios versions across repo. #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2021
Merged

updating android and ios versions across repo. #498

merged 3 commits into from
Jun 29, 2021

Conversation

vimanyu
Copy link
Contributor

@vimanyu vimanyu commented Jun 28, 2021

Updated android and ios dependencies.

@vimanyu vimanyu requested a review from jonsimantov June 28, 2021 23:47
@google-cla google-cla bot added the cla: yes label Jun 28, 2021
@vimanyu vimanyu self-assigned this Jun 28, 2021
@vimanyu vimanyu added the tests-requested: quick Trigger a quick set of integration tests. label Jun 28, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 28, 2021
@github-actions
Copy link

github-actions bot commented Jun 28, 2021 •
edited
Loading

❌  Integration test FAILED

Requested by @vimanyu on commit 3e86226
Last updated: Tue Jun 29 18:22 PDT 2021
View integration test log & download artifacts

Failures Configs
installations [TEST] [FAILURE] [Android] [windows, ubuntu] [android_latest]
(1 failed tests)  TestGettingTokenTwiceMatches

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 29, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 29, 2021
@vimanyu vimanyu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jun 29, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 29, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 29, 2021
@vimanyu vimanyu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jun 29, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 29, 2021
@vimanyu vimanyu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. labels Jun 29, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 29, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 29, 2021
@vimanyu vimanyu added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Jun 29, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jun 29, 2021
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jun 29, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 29, 2021
@vimanyu vimanyu removed the tests: failed This PR's integration tests failed. label Jun 29, 2021
@vimanyu
Copy link
Contributor Author

vimanyu commented Jun 29, 2021

Ignoring flaky test FirebaseMessagingTest.TestReceiveToken as it did not error in the previous runs.

@vimanyu vimanyu merged commit 3e86226 into main Jun 29, 2021
@vimanyu vimanyu deleted the feature/m98-release-update-dependencies branch June 29, 2021 23:05
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Jun 29, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 30, 2021
@firebase firebase locked and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@vimanyu vimanyu

Labels
cla: yes tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vimanyu @jonsimantov