Fix NPE in android_abis.gradle if ANDROID_NDK_HOME is not set #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NDROID_NDK_HOME") is not null prior to using it. This fixes the following cryptic build error if the "ANDROID_NDK_HOME" environment variable is not set: java.lang.NullPointerException: Cannot invoke method contains() on null object
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
✅ Integration test succeeded!Requested by @jonsimantov on commit 1439749 |
jonsimantov
approved these changes
Apr 20, 2021
jonsimantov
suggested changes
Apr 20, 2021
| if (System.getenv("ANDROID_NDK_HOME").contains("r16b") || | ||
| System.getenv("ANDROID_NDK_HOME").contains("r11c")) { | ||
| if (System.getenv("ANDROID_NDK_HOME") != null && ( | ||
| System.getenv("ANDROID_NDK_HOME").contains("r16b") || |
There was a problem hiding this comment.
Could you replace these tabs with spaces?
There was a problem hiding this comment.
It was spaces. Android Studio had formatted it like this. I tweaked it a bit. Let me know if you're okay with it now.
jonsimantov
approved these changes
Apr 20, 2021
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following cryptic build error if the "ANDROID_NDK_HOME" environment variable is not set: