Skip to content

Update generate_xml exectuable after change in PR #1223 #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2023
Merged

Update generate_xml exectuable after change in PR #1223 #1233

merged 1 commit into from
Mar 7, 2023

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Mar 7, 2023 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Updated the executable for generate_xml_from_google_services.exe after a change was made to the python version in #1223.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Packaging -> Integration Test

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@jonsimantov jonsimantov self-requested a review March 7, 2023 19:19
@DellaBitta DellaBitta added the skip-release-notes Skip release notes check label Mar 7, 2023
@DellaBitta DellaBitta merged commit e774aff into main Mar 7, 2023
@DellaBitta DellaBitta deleted the update/generate_xml branch March 7, 2023 19:22
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023 •
edited
Loading

❌  Integration test FAILED

Requested by @DellaBitta on commit e774aff
Last updated: Tue Mar 7 13:48 PST 2023
View integration test log & download artifacts

Failures Configs
analytics [TEST] [FAILURE] [Android] [All 3 os] [1/2 android_device: android_target]
(1 failed tests)  FirebaseAnalyticsTest.TestGetSessionID

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Mar 7, 2023
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 7, 2023
@firebase firebase locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DellaBitta @jonsimantov