Skip to content

Disable getSessionId test on emulators. #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 30, 2023
Merged

Disable getSessionId test on emulators. #1193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bbfd58
Disable getSessionId test on Android emulator.
jonsimantov Jan 25, 2023
9054fe3
Also skip on iOS simulator.
jonsimantov Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions analytics/integration_test/src/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,15 @@ TEST_F(FirebaseAnalyticsTest, TestGetAnalyticsInstanceID) {
}

TEST_F(FirebaseAnalyticsTest, TestGetSessionID) {
// Android emulator tests are currently not working due to getSessionId being
// disabled on virtual FTL devices, due to an older version of Google Play
// services.
SKIP_TEST_ON_ANDROID_EMULATOR;

// iOS simulator tests are currently extra flaky, occasionally failing with an
// "Analytics uninitialized" error even after multiple attempts.
SKIP_TEST_ON_IOS_SIMULATOR;

// On Android, if SetConsent was tested, this test will fail, since the app
// needs to be restarted after consent is denied or it won't generate a new
// sessionID. To not break the tests, skip this test in that case.
Expand Down