Skip to content

pthread_condvar.h: Fix ConditionVariable::TimedWait() on 32-bit platforms #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 8, 2022
Merged

pthread_condvar.h: Fix ConditionVariable::TimedWait() on 32-bit platforms #1044

merged 3 commits into from
Aug 8, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Aug 5, 2022 •
edited
Loading

Fix the templated overload of ConditionVariable::TimedWait(), which suffers from the same integer overflow bug on 32-bit architectures as Semaphore::TimedWait(int) did (which was fixed by #1042). Also, delete NormalizeTimespec() since it is no longer used anywhere.

@dconeybe dconeybe added the skip-release-notes Skip release notes check label Aug 5, 2022
@dconeybe dconeybe self-assigned this Aug 5, 2022
@dconeybe dconeybe changed the title Dconeybe/condition variable timed wait delete pthread_condvar.h: Delete ConditionVariable::TimedWait() Aug 5, 2022
@dconeybe dconeybe changed the title pthread_condvar.h: Delete ConditionVariable::TimedWait() pthread_condvar.h: Delete unused method ConditionVariable::TimedWait() Aug 5, 2022
@dconeybe dconeybe added the tests-requested: quick Trigger a quick set of integration tests. label Aug 5, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 5, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2022 •
edited
Loading

Integration test with FLAKINESS (succeeded after retry)

Requested by @dconeybe on commit fdb50b0
Last updated: Mon Aug 8 14:23 PDT 2022
View integration test log & download artifacts

Failures Configs
analytics [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Aug 5, 2022
@dconeybe dconeybe changed the title pthread_condvar.h: Delete unused method ConditionVariable::TimedWait() pthread_condvar.h: Fix ConditionVariable::TimedWait() on 32-bit platforms Aug 5, 2022
@dconeybe dconeybe added tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. labels Aug 5, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 5, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 5, 2022
@dconeybe dconeybe requested a review from jonsimantov August 6, 2022 00:21
@dconeybe dconeybe mentioned this pull request Aug 8, 2022
Merged
@dconeybe dconeybe merged commit fdb50b0 into main Aug 8, 2022
@dconeybe dconeybe deleted the dconeybe/ConditionVariableTimedWaitDelete branch August 8, 2022 18:17
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 8, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 8, 2022
@firebase firebase locked and limited conversation to collaborators Sep 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@jonsimantov jonsimantov jonsimantov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jonsimantov jonsimantov

@dconeybe dconeybe

Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dconeybe @jonsimantov