[test] Use ktor3 #7052
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,8 +45,8 @@ javalite = "3.25.5" | |
| jsonassert = "1.5.0" | ||
| kotest = "5.9.0" # Do not use 5.9.1 because it reverts the fix for https://github.com/kotest/kotest/issues/3981 | ||
| kotestAssertionsCore = "5.8.1" | ||
| kotlin = "2.0.21" | ||
|
There was a problem hiding this comment. FWIW Gradle 9 also uses Kotlin 2 :) |
||
| ktorVersion = "3.0.3" | ||
|
There was a problem hiding this comment. Upgrading Ktor from 2.3.2 to 3.0.3 is a major version change that typically includes breaking API changes. This PR updates the version number, but there are no corresponding code changes to adapt existing Ktor usage (if any) to the new Ktor 3.x APIs. If Ktor is currently used in the project, this change will likely cause compilation errors or runtime issues, preventing the goal stated in the PR title/description to "Test using ktor3". To effectively test Ktor 3, the necessary code adaptations for its new APIs should be included. If this PR is intended only as a version bump, with code changes to follow, please clarify this in the PR description. Otherwise, the required code modifications for Ktor 3 compatibility are missing. |
||
| legacySupportV4 = "1.0.0" | ||
| lifecycleProcess = "2.3.1" | ||
| material = "1.12.0" | ||
|
|
@@ -68,7 +68,7 @@ robolectric = "4.12" | |
| runner = "1.0.2" | ||
| rxandroid = "2.0.2" | ||
| rxjava = "2.1.14" | ||
| serialization = "1.7.3" | ||
|
There was a problem hiding this comment. The update from Kotlinx Serialization 1.5.1 to 1.7.3 is a significant version upgrade. While generally beneficial, major version changes can sometimes introduce subtle behavioral differences or require adjustments to build configurations and plugin compatibilities. It's crucial to perform thorough testing across the project to ensure everything compiles correctly and all existing tests pass. Pay attention to any new compiler diagnostics or runtime behaviors. |
||
| slf4jNop = "2.0.9" | ||
| spotless = "7.0.0.BETA3" | ||
| testServices = "1.2.0" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update from Kotlin 1.8.22 to 2.0.21 is a significant language version upgrade. While Kotlin 2.0 aims for backward compatibility and brings many improvements, major version changes can sometimes introduce subtle behavioral differences, new compiler warnings/errors, or require adjustments to build configurations and plugin compatibilities.
It's crucial to perform thorough testing across the project to ensure everything compiles correctly and all existing tests pass. Pay attention to any new compiler diagnostics or runtime behaviors.