Improve Real-time response Handling for Remote Config #7044
Conversation
Firebase AI Mock Responses Check
|
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @tusharkhandelwal8, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the Firebase Remote Config SDK's real-time response handling, particularly for scenarios where a project exceeds its real-time quota. My changes introduce a mechanism to receive and apply a server-provided retryInterval, ensuring that clients can immediately fetch the latest configuration template and then efficiently manage their real-time connection attempts based on the recommended interval. This approach aims to prevent user starvation and proactively prepares the SDK for future quota enforcement.
Highlights
- Quota Handling Improvement: The SDK now processes a
retryIntervalSecondsfield from real-time responses. This allows the server to dictate when a client should re-establish its connection after hitting a quota limit, ensuring a more graceful and efficient handling of quota exceedances. - Dynamic Backoff Management: A new method,
updateBackoffMetadataWithRetryInterval, has been added toConfigAutoFetch. This method calculates and persists a new backoff end time based on the receivedretryInterval, ensuring clients respect server-recommended delays before retrying real-time connections. - Shared Preferences Integration: The
ConfigSharedPrefsClientis now passed tolistenForNotificationsandhandleNotificationsmethods withinConfigAutoFetch. This enables the persistence of the dynamically calculated backoff end time, allowing the SDK to maintain state across sessions. - Persistence of Retry Interval: A new public method
setRealtimeBackoffEndTimehas been added toConfigSharedPrefsClientto store the calculated backoff end time in shared preferences, ensuring the retry logic is consistently applied. - Enhanced Test Coverage: A new test case,
realtime_updatesBackoffMetadataWithProvidedRetryInterval, has been added toFirebaseRemoteConfigTest. This test specifically verifies that the SDK correctly processes theretryIntervalSecondsfrom the server response and updates the backoff metadata accordingly.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces improvements to how the Firebase SDK handles real-time requests when a Firebase project has exceeded its available quota for real-time services. The SDK now respects a server-provided retry interval for real-time Remote Config connections. The changes are well-scoped, the logic is sound, and a new test case validates the core new functionality. No issues of medium, high, or critical severity were identified.
Test Results 42 files - 1 016 42 suites - 1 016 1m 21s ⏱️ - 34m 31s Results for commit 98d4815. ± Comparison against base commit f08e0c7. This pull request removes 5661 and adds 1 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
Coverage Report 1Affected ProductsNo changes between base commit (8329493) and merge commit (bae7e60).Test Logs |
Size Report 1Affected Products
Test Logs |
firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigAutoFetch.java
Outdated
Show resolved
Hide resolved
firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigAutoFetch.java
Outdated
Show resolved
Hide resolved
This change prepares the Firebase SDK for future real-time quota enforcement, addressing potential user starvation. It ensures the SDK can fetch the latest template even when the real-time quota is exceeded.
We now include a retryInterval in the response when a connection hits a quota limit. This allows clients to get the latest template immediately and retry the connection after the specified interval. This approach guarantees users always have access to the latest data and can efficiently resume real-time services once their quota is restored.