Skip to content

Rename ConfigMetadataClient to ConfigSharedPrefsClient #6537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

tusharkhandelwal8
Copy link
Contributor

@tusharkhandelwal8 tusharkhandelwal8 commented Nov 27, 2024

Reflects expanded functionality to store both metadata and custom signals in shared preferences.

@tusharkhandelwal8 tusharkhandelwal8 changed the title Rename ConfigMetadataClient to ConfigSharedPrefsClient Reflects expanded functionality to store both metadata and custom signals in shared preferences. Rename ConfigMetadataClient to ConfigSharedPrefsClient Nov 27, 2024
Copy link
Contributor

github-actions bot commented Nov 27, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@tusharkhandelwal8 tusharkhandelwal8 changed the base branch from main to remoteConfigCustomTargeting November 27, 2024 05:59
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from 84.11% (c00de5a) to 84.12% (3ecb2b4) by +0.01%.

    FilenameBase (c00de5a)Merge (3ecb2b4)Diff
    ConfigFetchHandler.java92.86%92.90%+0.04%
    ConfigSharedPrefsClient.java?92.31%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/c6zVkHgzne.html

Copy link
Contributor

Test Results

 40 files  + 32   40 suites  +32   1m 25s ⏱️ +59s
309 tests +287  309 ✅ +287  0 💤 ±0  0 ❌ ±0 
630 runs  +586  630 ✅ +586  0 💤 ±0  0 ❌ ±0 

Results for commit ddb531c. ± Comparison against base commit c00de5a.

This pull request removes 22 and adds 309 tests. Note that renamed tests count towards both.
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testDefaultDataCollection_usedWhenNoOverrideOrManifestSetting
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testManifestMetadata_respectedWhenNoOverride
com.google.firebase.crashlytics.internal.common.DataCollectionArbiterRobolectricTest ‑ testSetCrashlyticsDataCollectionEnabled_overridesOtherSettings
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
…
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance()
com.google.firebase.remoteconfig.ConfigTests ‑ Firebase#remoteConfig should delegate to FirebaseRemoteConfig#getInstance(FirebaseApp, region)
com.google.firebase.remoteconfig.ConfigTests ‑ FirebaseRemoteConfigSettings builder works
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns default value when key doesn't exist
com.google.firebase.remoteconfig.ConfigTests ‑ Overloaded get() operator returns value when key exists
com.google.firebase.remoteconfig.FirebaseRemoteConfigSettingsTest ‑ toBuilder_withFieldsSet_buildsObjectWithFieldsSet
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate2p_hasNoAbtExperiments_doesNotCallAbt
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_callToAbtFails_activateStillSucceeds
com.google.firebase.remoteconfig.FirebaseRemoteConfigTest ‑ activate_configWithRolloutMetadata_storedInActivatedCacheSuccessfully
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-config

    TypeBase (c00de5a)Merge (3ecb2b4)Diff
    aar108 kB108 kB+52 B (+0.0%)
    apk (release)4.58 MB4.58 MB+16 B (+0.0%)
  • firebase-config-ktx

    TypeBase (c00de5a)Merge (3ecb2b4)Diff
    apk (release)4.58 MB4.58 MB+16 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ACDysox3lC.html

@themiswang themiswang self-requested a review November 27, 2024 15:35
@tusharkhandelwal8 tusharkhandelwal8 merged commit 5f75cc8 into remoteConfigCustomTargeting Nov 27, 2024
41 checks passed
@tusharkhandelwal8 tusharkhandelwal8 deleted the renaming branch November 27, 2024 16:19
@firebase firebase locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants