Skip to content

Rename ConfigMetadataClient to ConfigSharedPrefsClient #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2024
Merged

Rename ConfigMetadataClient to ConfigSharedPrefsClient #6440

merged 2 commits into from
Nov 23, 2024

Conversation

tusharkhandelwal8
Copy link
Contributor

Rename ConfigMetadataClient to ConfigSharedPrefsClient

Reflects expanded functionality to store both metadata and custom signals in shared preferences.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024 •
edited
Loading

Test Results

 40 files  ±0   40 suites  ±0   1m 28s ⏱️ ±0s
313 tests ±0  313 ✅ ±0  0 💤 ±0  0 ❌ ±0 
638 runs  ±0  638 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 84e4c81. ± Comparison against base commit 5a15867.

♻️ This comment has been updated with latest results.

@tusharkhandelwal8 tusharkhandelwal8 mentioned this pull request Nov 7, 2024
Merged
@tusharkhandelwal8
Merge branch 'refs/heads/tushar-khandelwal/rc-custom-targeting' into …
84e4c81 
…tushar-khandelwal/rename-configmetadataclient

# Conflicts:
#	firebase-config/src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java
#	firebase-config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigSharedPrefsClient.java
#	firebase-config/src/test/java/com/google/firebase/remoteconfig/internal/ConfigSharedPrefsClientTest.java
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from ? (5a15867) to 83.19% (2497b1a) by ?.

    34 individual files with coverage change

    FilenameBase (5a15867)Merge (2497b1a)Diff
    AutoValue_ConfigUpdate.java?29.41%?
    Code.java?0.00%?
    ConfigAutoFetch.java?87.74%?
    ConfigCacheClient.java?93.33%?
    ConfigContainer.java?94.29%?
    ConfigFetchHandler.java?92.90%?
    ConfigFetchHttpClient.java?87.58%?
    ConfigGetParameterHandler.java?96.45%?
    ConfigRealtimeHandler.java?41.38%?
    ConfigRealtimeHttpClient.java?68.93%?
    ConfigSharedPrefsClient.java?87.34%?
    ConfigStorageClient.java?100.00%?
    ConfigUpdate.java?100.00%?
    ConfigUpdateListener.java?0.00%?
    ConfigUpdateListenerRegistration.java?0.00%?
    CustomSignals.java?0.00%?
    DefaultsXmlParser.java?0.00%?
    FirebaseRemoteConfig.java?87.40%?
    FirebaseRemoteConfigClientException.java?75.00%?
    FirebaseRemoteConfigException.java?95.65%?
    FirebaseRemoteConfigFetchThrottledException.java?100.00%?
    FirebaseRemoteConfigInfo.java?0.00%?
    FirebaseRemoteConfigInfoImpl.java?100.00%?
    FirebaseRemoteConfigServerException.java?68.42%?
    FirebaseRemoteConfigSettings.java?61.54%?
    FirebaseRemoteConfigValue.java?0.00%?
    FirebaseRemoteConfigValueImpl.java?84.62%?
    Personalization.java?91.43%?
    RemoteConfig.kt?31.58%?
    RemoteConfigComponent.java?90.80%?
    RemoteConfigConstants.java?0.00%?
    RemoteConfigRegistrar.java?100.00%?
    RolloutsStateFactory.java?95.24%?
    RolloutsStateSubscriptionsHandler.java?100.00%?

  • firebase-config-ktx

    Overall coverage changed from ? (5a15867) to 100.00% (2497b1a) by ?.

    FilenameBase (5a15867)Merge (2497b1a)Diff
    Logging.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/nU2Bf0PdHb.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (5a15867)Merge (2497b1a)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-config

    TypeBase (5a15867)Merge (2497b1a)Diff
    aar?111 kB? (?)
    apk (aggressive)?211 kB? (?)
    apk (release)?4.59 MB? (?)

  • firebase-config-ktx

    TypeBase (5a15867)Merge (2497b1a)Diff
    aar?3.26 kB? (?)
    apk (aggressive)?211 kB? (?)
    apk (release)?4.59 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/k4kBLxNcK5.html

@tusharkhandelwal8 tusharkhandelwal8 merged commit 21a39c5 into tushar-khandelwal/rc-custom-targeting Nov 23, 2024
34 checks passed
@tusharkhandelwal8 tusharkhandelwal8 deleted the tushar-khandelwal/rename-configmetadataclient branch November 23, 2024 05:23
@firebase firebase locked and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@themiswang themiswang themiswang approved these changes

@karenyz karenyz karenyz approved these changes

Assignees
No one assigned
Labels
no-changelog size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tusharkhandelwal8 @google-oss-bot @themiswang @karenyz