-
Notifications
You must be signed in to change notification settings - Fork 626
Add custom signals support in Remote Config. #6410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tusharkhandelwal8
merged 22 commits into
remoteConfigCustomTargeting
from
tushar-khandelwal/rc-custom-targeting
Dec 9, 2024
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
86ee29c
Add support for custom signals
tusharkhandelwal8 b241027
Add support for custom signals
tusharkhandelwal8 bb8336a
Merge remote-tracking branch 'origin/tushar-khandelwal/rc-custom-targ…
tusharkhandelwal8 ff596ae
Fix lint and build errors.
tusharkhandelwal8 2a678f6
Fix lint and build errors.
tusharkhandelwal8 bd05e9d
Merge remote-tracking branch 'origin/tushar-khandelwal/rc-custom-targ…
tusharkhandelwal8 60ae034
update the API definition file to include setCustomSignals
tusharkhandelwal8 d1cac74
Add limits, input validation, and unit tests for custom signals
tusharkhandelwal8 07ae4d4
Merge branch 'refs/heads/main' into tushar-khandelwal/rc-custom-targe…
tusharkhandelwal8 917a462
Rename ConfigMetadataClient to ConfigSharedPrefsClient in a different…
tusharkhandelwal8 deb3d84
Rename ConfigMetadataClient to ConfigSharedPrefsClient in a different…
tusharkhandelwal8 1e172a4
Merge remote-tracking branch 'origin/tushar-khandelwal/rc-custom-targ…
tusharkhandelwal8 92814b7
Log warnings for invalid custom signals.
tusharkhandelwal8 288dcd1
Add CustomSignals type for restricted values in setCustomSignals.
tusharkhandelwal8 88f268f
Add put(String, double) to the CustomSignals.Builder API definition
tusharkhandelwal8 ccd4b2e
Fix Formating
tusharkhandelwal8 5a15867
Fix Formating for custom signal limits
tusharkhandelwal8 21a39c5
Rename ConfigMetadataClient to ConfigSharedPrefsClient (#6440)
tusharkhandelwal8 3e94fe3
Improve Kotlin API, add logs and tests
tusharkhandelwal8 5a41f0d
Update API definition file to include kotlin
tusharkhandelwal8 becb76d
Merge branch 'refs/heads/remoteConfigCustomTargeting' into tushar-kha…
tusharkhandelwal8 c6b9c56
Update test and rename customSignalsMap to customSignals
tusharkhandelwal8 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
firebase-config/src/main/java/com/google/firebase/remoteconfig/CustomSignals.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
// Copyright 2024 Google LLC | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
package com.google.firebase.remoteconfig; | ||
|
||
import androidx.annotation.NonNull; | ||
import androidx.annotation.Nullable; | ||
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
/** | ||
* Helper class which handles the storage and conversion to strings of key/value pairs with | ||
* heterogeneous value types for custom signals. | ||
*/ | ||
public class CustomSignals { | ||
|
||
final Map<String, String> customSignals; | ||
|
||
public static class Builder { | ||
// Holds the converted pairs of custom keys and values. | ||
private Map<String, String> customSignals = new HashMap<String, String>(); | ||
|
||
// Methods to accept keys and values and convert values to strings. | ||
@NonNull | ||
public Builder put(@NonNull String key, @Nullable String value) { | ||
customSignals.put(key, value); | ||
return this; | ||
} | ||
|
||
@NonNull | ||
public Builder put(@NonNull String key, long value) { | ||
customSignals.put(key, Long.toString(value)); | ||
return this; | ||
} | ||
|
||
@NonNull | ||
public Builder put(@NonNull String key, double value) { | ||
customSignals.put(key, Double.toString(value)); | ||
return this; | ||
} | ||
|
||
@NonNull | ||
public CustomSignals build() { | ||
return new CustomSignals(this); | ||
} | ||
} | ||
|
||
CustomSignals(@NonNull Builder builder) { | ||
this.customSignals = builder.customSignals; | ||
} | ||
} |
tusharkhandelwal8 marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.