Skip to content

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Apr 18, 2023

Update versions since last release

@rlazo rlazo requested a review from VinayGuthal April 18, 2023 14:41
@rlazo rlazo enabled auto-merge (squash) April 18, 2023 14:41
@github-actions
Copy link
Contributor

github-actions bot commented Apr 18, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.16% (c719f85) to 50.13% (155ceb5) by -0.03%.

    FilenameBase (c719f85)Merge (155ceb5)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    ViewProcessor.java91.79%92.10%+0.30%
  • firebase-firestore

    Overall coverage changed from 44.12% (c719f85) to 44.10% (155ceb5) by -0.02%.

    FilenameBase (c719f85)Merge (155ceb5)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    LocalStore.java100.00%99.39%-0.61%
    LruGarbageCollector.java97.20%93.46%-3.74%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kNTd4gUZhN.html

@github-actions
Copy link
Contributor

Unit Test Results

   352 files  +   318     352 suites  +318   9m 13s ⏱️ + 8m 1s
2 719 tests +2 662  2 701 ✔️ +2 644  18 💤 +18  0 ±0 
5 438 runs  +5 324  5 402 ✔️ +5 288  36 💤 +36  0 ±0 

Results for commit b66c300. ± Comparison against base commit c719f85.

This pull request removes 57 and adds 2719 tests. Note that renamed tests count towards both.
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPostNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_shouldDefaultToTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsFalse_shouldReturnFalse
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ isDataCollectionDefaultEnabled_whenPrefsTrue_shouldReturnTrue
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabledFalse_shouldUpdateSharedPrefs
com.google.firebase.DataCollectionPreNDefaultEnabledTest ‑ setDataCollectionDefaultEnabled_shouldNotAffectOtherFirebaseAppInstances
…
com.google.firebase.TimestampTest ‑ testCompare
com.google.firebase.TimestampTest ‑ testFromDate
com.google.firebase.TimestampTest ‑ testRejectBadDates
com.google.firebase.TimestampTest ‑ testTimestampParcelable
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_emptyLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_isNotRedirectResponse_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_missingLocationHeader_setsDownloadFailure
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_onAppResume_setsUpdateCancelled
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenAabReleaseAvailable_redirectsToPlay
com.google.firebase.appdistribution.impl.AabUpdaterTest ‑ updateAppTask_whenOpenConnectionFails_setsNetworkFailure
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (c719f85)Merge (155ceb5)Diff
    aar247 kB247 kB+3 B (+0.0%)
  • firebase-appdistribution-api

    TypeBase (c719f85)Merge (155ceb5)Diff
    aar16.0 kB16.0 kB-1 B (-0.0%)
  • firebase-database

    TypeBase (c719f85)Merge (155ceb5)Diff
    apk (release)1.72 MB1.72 MB+4 B (+0.0%)
  • firebase-datatransport

    TypeBase (c719f85)Merge (155ceb5)Diff
    aar4.94 kB4.94 kB-1 B (-0.0%)
    apk (release)1.35 MB1.35 MB+4 B (+0.0%)
  • firebase-encoders-json

    TypeBase (c719f85)Merge (155ceb5)Diff
    apk (release)596 kB596 kB+4 B (+0.0%)
  • firebase-firestore

    TypeBase (c719f85)Merge (155ceb5)Diff
    aar1.33 MB1.33 MB-1 B (-0.0%)
    apk (release)3.94 MB3.94 MB-8 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4mFAkOncBc.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (155ceb5) and the base commit (c719f85) are not available.

No macrobenchmark data found for the base commit (c719f85). Analysis for the CI merge commit (155ceb5) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/AKw3w9IcPz/index.html

@rlazo rlazo merged commit 0451fa0 into master Apr 19, 2023
@rlazo rlazo deleted the rl.ver.m130 branch April 19, 2023 14:38
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants