Skip to content

QueryTest.java: Remove check for getTargetBackend() != NIGHTLY #4871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2023
Merged

QueryTest.java: Remove check for getTargetBackend() != NIGHTLY #4871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,14 +1148,6 @@ public void resumingAQueryShouldUseBloomFilterToAvoidFullRequery() throws Except
.that(existenceFilterMismatchInfo.existenceFilterCount())
.isEqualTo(50);

// Skip the verification of the bloom filter when testing against production because the bloom
// filter is only implemented in nightly.
// TODO(b/271949433) Remove this "if" block once the bloom filter logic is deployed to
// production.
if (IntegrationTestUtil.getTargetBackend() != IntegrationTestUtil.TargetBackend.NIGHTLY) {
return;
}

// Verify that Watch sent a valid bloom filter.
ExistenceFilterMismatchListener.ExistenceFilterBloomFilterInfo bloomFilter =
existenceFilterMismatchInfo.bloomFilter();
Expand Down