Skip to content

Report updated experiments if either experiment id or variant id changes. #4555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 14, 2023
Merged

Report updated experiments if either experiment id or variant id changes. #4555

merged 5 commits into from
Jan 14, 2023

Conversation

@danasilver
Copy link
Contributor

@danasilver danasilver commented Jan 12, 2023 •
edited
Loading

Considering experiments changed if either experiment id or variant id changes aligns with how the A/B testing SDK for iOS behaves.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 12, 2023 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-abt

    Overall coverage changed from ? (7848cc1) to 82.01% (cd3c1f1) by ?.

    FilenameBase (7848cc1)Merge (cd3c1f1)Diff
    AbtComponent.java?0.00%?
    AbtException.java?50.00%?
    AbtExperimentInfo.java?86.15%?
    AbtRegistrar.java?0.00%?
    FirebaseABTesting.java?97.98%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4fBq7uKTDE.html

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023 •
edited
Loading

Unit Test Results

  35 files   -    367    35 suites   - 367   1m 19s ⏱️ - 1h 10m 53s
523 tests  - 4 237  523 ✔️  - 4 202  0 💤  - 22  0 ❌  - 13 
523 runs   - 4 253  523 ✔️  - 4 218  0 💤  - 22  0 ❌  - 13 

Results for commit c644b7d. ± Comparison against base commit 9226348.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 12, 2023 •
edited
Loading

Size Report 1

Affected Products

  • firebase-abt

    TypeBase (7848cc1)Merge (cd3c1f1)Diff
    aar13.8 kB13.8 kB-19 B (-0.1%)
    apk (release)1.27 MB1.27 MB+96 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/mSs7Yx1xiP.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 12, 2023 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (cd3c1f1) and the base commit (7848cc1) are not available.

No macrobenchmark data found for the base commit (7848cc1). Analysis for the CI merge commit (cd3c1f1) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/32RaHWgXKZ/index.html

@danasilver danasilver marked this pull request as ready for review January 12, 2023 20:30
@danasilver danasilver requested a review from karenyz January 12, 2023 20:30
@danasilver danasilver requested a review from karenyz January 12, 2023 23:38
@danasilver danasilver merged commit df79e47 into master Jan 14, 2023
@danasilver danasilver deleted the ds-abt-variant-id branch January 14, 2023 01:34
mrober pushed a commit that referenced this pull request Jan 30, 2023
@danasilver @mrober
Report updated experiments if either experiment id or variant id chan…
f829d31 
…ges. (#4555)
@firebase firebase locked and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@karenyz karenyz karenyz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danasilver @google-oss-bot @karenyz