-
Notifications
You must be signed in to change notification settings - Fork 651
Extend publishing plugin to support release configFiles. #4552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the plugin to read the list of projects to be released from a configuration file, besides getting them from the CLI.
Contributor
Javadoc Changes:--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appdistribution/AppDistributionRelease.html 2023-01-12 23:20:33.803430743 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appdistribution/AppDistributionRelease.html 2023-01-12 23:14:32.074482654 +0000
@@ -21,7 +21,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code>abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+ <td width="40%"><code>abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a></code></td>
<td>
<div><code><a href="/docs/reference/android/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</code></div>
<p>Returns the binary type for this build.</p>
@@ -54,7 +54,7 @@
<h2>Public methods</h2>
<div><a name="getBinaryType--"></a><a name="getbinarytype"></a>
<h3 class="api-name" id="getBinaryType()">getBinaryType</h3>
- <pre class="api-signature no-pretty-print">abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</pre>
+ <pre class="api-signature no-pretty-print">abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</pre>
<p>Returns the binary type for this build.</p>
</div>
<div><a name="getDisplayVersion--"></a><a name="getdisplayversion"></a>--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html 2023-01-12 23:19:25.458850444 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html 2023-01-12 23:13:22.320589440 +0000
@@ -59,7 +59,7 @@
<tr>
<td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>></code></td>
<td>
- <div><code><a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> modelName,<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a> downloadType,<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a> conditions<br>)</code></div>
+ <div><code><a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> modelName,<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> downloadType,<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a> conditions<br>)</code></div>
<p>Gets the downloaded model file based on download type and conditions.</p>
</td>
</tr>
@@ -178,7 +178,7 @@
</div>
<div><a name="getModel(java.lang.String, com.google.firebase.ml.modeldownloader.DownloadType, com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)"></a><a name="getModel-java.lang.String-com.google.firebase.ml.modeldownloader.DownloadType-com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions-"></a><a name="getmodel"></a>
<h3 class="api-name" id="getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</h3>
- <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> modelName,<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a> downloadType,<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a> conditions<br>)</pre>
+ <pre class="api-signature no-pretty-print">public @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a> modelName,<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> downloadType,<br> @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a> conditions<br>)</pre>
<p>Gets the downloaded model file based on download type and conditions. DownloadType behaviours: </p>
<ul>
<li><code><a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html#LOCAL_MODEL">DownloadType#LOCAL_MODEL</a></code>: returns the current model if present, otherwise triggers new download (or finds one in progress) and only completes when download is finished </li>
@@ -207,7 +207,7 @@
</td>
</tr>
<tr>
- <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a> downloadType</code></td>
+ <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a> downloadType</code></td>
<td>
<p><code><a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a></code> to determine which model to return.</p>
</td>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html 2023-01-12 23:20:33.831430928 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html 2023-01-12 23:14:32.098483303 +0000
@@ -21,7 +21,7 @@
</thead>
<tbody class="list">
<tr>
- <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
+ <td width="40%"><code><a href="/docs/reference/kotlin/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a></code></td>
<td>
<div><code><a href="/docs/reference/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</code></div>
<p>Returns the binary type for this build.</p>
@@ -54,7 +54,7 @@
<h2>Public functions</h2>
<div><a name="getBinaryType--"></a><a name="getbinarytype"></a>
<h3 class="api-name" id="getBinaryType()">getBinaryType</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>(): <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></pre>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>(): <a href="/docs/reference/kotlin/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a></pre>
<p>Returns the binary type for this build.</p>
</div>
<div><a name="getDisplayVersion--"></a><a name="getdisplayversion"></a>--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html 2023-01-12 23:19:25.470850554 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html 2023-01-12 23:13:22.340590009 +0000
@@ -59,7 +59,7 @@
<tr>
<td width="40%"><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>!></code></td>
<td>
- <div><code><a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br> modelName: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,<br> downloadType: <a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a>,<br> conditions: <a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>?<br>)</code></div>
+ <div><code><a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br> modelName: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,<br> downloadType: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>,<br> conditions: <a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>?<br>)</code></div>
<p>Gets the downloaded model file based on download type and conditions.</p>
</td>
</tr>
@@ -178,7 +178,7 @@
</div>
<div><a name="getModel(java.lang.String, com.google.firebase.ml.modeldownloader.DownloadType, com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)"></a><a name="getModel-java.lang.String-com.google.firebase.ml.modeldownloader.DownloadType-com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions-"></a><a name="getmodel"></a>
<h3 class="api-name" id="getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</h3>
- <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br> modelName: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,<br> downloadType: <a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a>,<br> conditions: <a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>?<br>): <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>!></pre>
+ <pre class="api-signature no-pretty-print">fun <a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br> modelName: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,<br> downloadType: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>,<br> conditions: <a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>?<br>): <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a><<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>!></pre>
<p>Gets the downloaded model file based on download type and conditions. DownloadType behaviours: </p>
<ul>
<li><code><a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html#LOCAL_MODEL">DownloadType#LOCAL_MODEL</a></code>: returns the current model if present, otherwise triggers new download (or finds one in progress) and only completes when download is finished </li>
@@ -207,7 +207,7 @@
</td>
</tr>
<tr>
- <td width="40%"><code>downloadType: <a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a></code></td>
+ <td width="40%"><code>downloadType: <a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
<td>
<p><code><a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a></code> to determine which model to return.</p>
</td> |
Contributor
Contributor
Size Report 1Affected Products
Test Logs |
Contributor
Contributor
Coverage Report 1Affected Products
Test Logs |
buildSrc/src/main/java/com/google/firebase/gradle/plugins/publish/PublishingPlugin.java
Show resolved
Hide resolved
rlazo
commented
Jan 12, 2023
Collaborator
Author
rlazo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add comment to the stream
emilypgoogle
approved these changes
Jan 12, 2023
daymxn
reviewed
Jan 12, 2023
buildSrc/src/main/java/com/google/firebase/gradle/plugins/publish/PublishingPlugin.java
Outdated
Show resolved
Hide resolved
daymxn
reviewed
Jan 12, 2023
buildSrc/src/main/java/com/google/firebase/gradle/plugins/publish/PublishingPlugin.java
Show resolved
Hide resolved
daymxn
reviewed
Jan 12, 2023
buildSrc/src/main/java/com/google/firebase/gradle/plugins/publish/PublishingPlugin.java
Show resolved
Hide resolved
mrober
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Extend publishing plugin to support release configFiles. This enables the plugin to read the list of projects to be released from a configuration file, besides getting them from the CLI. * Throw exception to force the build to fail. * Add comment to the skip line * Address review comments * Include an example of the contents of the release config file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the plugin to read the list of projects to be released from a configuration file, besides getting them from the CLI.