Skip to content

Conversation

@rlazo
Copy link
Collaborator

@rlazo rlazo commented Jan 12, 2023

This enables the plugin to read the list of projects to be released from a configuration file, besides getting them from the CLI.

This enables the plugin to read the list of projects to be released
from a configuration file, besides getting them from the CLI.
@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023

Javadoc Changes:
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/appdistribution/AppDistributionRelease.html	2023-01-12 23:20:33.803430743 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/appdistribution/AppDistributionRelease.html	2023-01-12 23:14:32.074482654 +0000
@@ -21,7 +21,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td width="40%"><code>abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a></code></td>
+            <td width="40%"><code>abstract @<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a></code></td>
             <td>
               <div><code><a href="/docs/reference/android/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</code></div>
               <p>Returns the binary type for this build.</p>
@@ -54,7 +54,7 @@
     <h2>Public methods</h2>
     <div><a name="getBinaryType--"></a><a name="getbinarytype"></a>
       <h3 class="api-name" id="getBinaryType()">getBinaryType</h3>
-      <pre class="api-signature no-pretty-print">abstract&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</pre>
+      <pre class="api-signature no-pretty-print">abstract&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a>&nbsp;<a href="/docs/reference/android/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</pre>
       <p>Returns the binary type for this build.</p>
     </div>
     <div><a name="getDisplayVersion--"></a><a name="getdisplayversion"></a>
--- /home/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html	2023-01-12 23:19:25.458850444 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html	2023-01-12 23:13:22.320589440 +0000
@@ -59,7 +59,7 @@
           <tr>
             <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>&gt;</code></td>
             <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;modelName,<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a>&nbsp;downloadType,<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>&nbsp;conditions<br>)</code></div>
+              <div><code><a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;modelName,<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;downloadType,<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>&nbsp;conditions<br>)</code></div>
               <p>Gets the downloaded model file based on download type and conditions.</p>
             </td>
           </tr>
@@ -178,7 +178,7 @@
     </div>
     <div><a name="getModel(java.lang.String, com.google.firebase.ml.modeldownloader.DownloadType, com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)"></a><a name="getModel-java.lang.String-com.google.firebase.ml.modeldownloader.DownloadType-com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions-"></a><a name="getmodel"></a>
       <h3 class="api-name" id="getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</h3>
-      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>&gt;&nbsp;<a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;modelName,<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a>&nbsp;downloadType,<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>&nbsp;conditions<br>)</pre>
+      <pre class="api-signature no-pretty-print">public&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>&gt;&nbsp;<a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;modelName,<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;downloadType,<br>&nbsp;&nbsp;&nbsp;&nbsp;@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/Nullable.html">Nullable</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>&nbsp;conditions<br>)</pre>
       <p>Gets the downloaded model file based on download type and conditions. DownloadType behaviours: </p>
       <ul>
         <li><code><a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html#LOCAL_MODEL">DownloadType#LOCAL_MODEL</a></code>: returns the current model if present, otherwise triggers new download (or finds one in progress) and only completes when download is finished </li>
@@ -207,7 +207,7 @@
               </td>
             </tr>
             <tr>
-              <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a>&nbsp;downloadType</code></td>
+              <td width="40%"><code>@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/Object.html">Object</a>&nbsp;downloadType</code></td>
               <td>
                 <p><code><a href="/docs/reference/android/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a></code> to determine which model to return.</p>
               </td>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html	2023-01-12 23:20:33.831430928 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html	2023-01-12 23:14:32.098483303 +0000
@@ -21,7 +21,7 @@
         </thead>
         <tbody class="list">
           <tr>
-            <td width="40%"><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
+            <td width="40%"><code><a href="/docs/reference/kotlin/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a></code></td>
             <td>
               <div><code><a href="/docs/reference/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>()</code></div>
               <p>Returns the binary type for this build.</p>
@@ -54,7 +54,7 @@
     <h2>Public functions</h2>
     <div><a name="getBinaryType--"></a><a name="getbinarytype"></a>
       <h3 class="api-name" id="getBinaryType()">getBinaryType</h3>
-      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>():&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></pre>
+      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appdistribution/AppDistributionRelease.html#getBinaryType()">getBinaryType</a>():&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/appdistribution/BinaryType.html">BinaryType</a></pre>
       <p>Returns the binary type for this build.</p>
     </div>
     <div><a name="getDisplayVersion--"></a><a name="getdisplayversion"></a>
--- /home/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html	2023-01-12 23:19:25.470850554 +0000
+++ /home/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html	2023-01-12 23:13:22.340590009 +0000
@@ -59,7 +59,7 @@
           <tr>
             <td width="40%"><code><a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>!&gt;</code></td>
             <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br>&nbsp;&nbsp;&nbsp;&nbsp;modelName:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,<br>&nbsp;&nbsp;&nbsp;&nbsp;downloadType:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a>,<br>&nbsp;&nbsp;&nbsp;&nbsp;conditions:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>?<br>)</code></div>
+              <div><code><a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br>&nbsp;&nbsp;&nbsp;&nbsp;modelName:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,<br>&nbsp;&nbsp;&nbsp;&nbsp;downloadType:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>,<br>&nbsp;&nbsp;&nbsp;&nbsp;conditions:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>?<br>)</code></div>
               <p>Gets the downloaded model file based on download type and conditions.</p>
             </td>
           </tr>
@@ -178,7 +178,7 @@
     </div>
     <div><a name="getModel(java.lang.String, com.google.firebase.ml.modeldownloader.DownloadType, com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)"></a><a name="getModel-java.lang.String-com.google.firebase.ml.modeldownloader.DownloadType-com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions-"></a><a name="getmodel"></a>
       <h3 class="api-name" id="getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</h3>
-      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br>&nbsp;&nbsp;&nbsp;&nbsp;modelName:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,<br>&nbsp;&nbsp;&nbsp;&nbsp;downloadType:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a>,<br>&nbsp;&nbsp;&nbsp;&nbsp;conditions:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>?<br>):&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>!&gt;</pre>
+      <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/FirebaseModelDownloader.html#getModel(java.lang.String,com.google.firebase.ml.modeldownloader.DownloadType,com.google.firebase.ml.modeldownloader.CustomModelDownloadConditions)">getModel</a>(<br>&nbsp;&nbsp;&nbsp;&nbsp;modelName:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>,<br>&nbsp;&nbsp;&nbsp;&nbsp;downloadType:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a>,<br>&nbsp;&nbsp;&nbsp;&nbsp;conditions:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModelDownloadConditions.html">CustomModelDownloadConditions</a>?<br>):&nbsp;<a href="https://developers.google.com/android/reference/com/google/android/gms/tasks/Task.html">Task</a>&lt;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/CustomModel.html">CustomModel</a>!&gt;</pre>
       <p>Gets the downloaded model file based on download type and conditions. DownloadType behaviours: </p>
       <ul>
         <li><code><a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html#LOCAL_MODEL">DownloadType#LOCAL_MODEL</a></code>: returns the current model if present, otherwise triggers new download (or finds one in progress) and only completes when download is finished </li>
@@ -207,7 +207,7 @@
               </td>
             </tr>
             <tr>
-              <td width="40%"><code>downloadType:&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a></code></td>
+              <td width="40%"><code>downloadType:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-any/index.html">Any</a></code></td>
               <td>
                 <p><code><a href="/docs/reference/kotlin/com/google/firebase/ml/modeldownloader/DownloadType.html">DownloadType</a></code> to determine which model to return.</p>
               </td>

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2023

Unit Test Results

   402 files  +   323     402 suites  +323   19m 9s ⏱️ + 18m 20s
4 760 tests +3 648  4 738 ✔️ +3 642  22 💤 +6  0 ±0 
4 776 runs  +3 664  4 754 ✔️ +3 658  22 💤 +6  0 ±0 

Results for commit 5d2af38. ± Comparison against base commit 1ddbc90.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 12, 2023

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 12, 2023

Startup Time Report 1

The report is too large (117,080 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SRz8ao4oqk/index.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 12, 2023

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.07% (1ddbc90) to 50.15% (c075a3b) by +0.09%.

    FilenameBase (1ddbc90)Merge (c075a3b)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
    WebsocketConnection.java32.77%35.03%+2.26%
  • firebase-firestore

    Overall coverage changed from 44.54% (1ddbc90) to 44.53% (c075a3b) by -0.00%.

    FilenameBase (1ddbc90)Merge (c075a3b)Diff
    PatchMutation.java100.00%98.39%-1.61%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/tEUSUZCuSx.html

Copy link
Collaborator Author

@rlazo rlazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment to the stream

@rlazo rlazo requested a review from emilypgoogle January 12, 2023 17:28
@rlazo rlazo enabled auto-merge (squash) January 12, 2023 18:27
@rlazo rlazo requested a review from daymxn January 12, 2023 18:28
@rlazo rlazo merged commit 9226348 into master Jan 12, 2023
@rlazo rlazo deleted the rl.publishreleaes882 branch January 12, 2023 23:25
mrober pushed a commit that referenced this pull request Jan 30, 2023
* Extend publishing plugin to support release configFiles.

This enables the plugin to read the list of projects to be released
from a configuration file, besides getting them from the CLI.

* Throw exception to force the build to fail.

* Add comment to the skip line

* Address review comments

* Include an example of the contents of the release config file
@firebase firebase locked and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants