Move Firebase Installations to the new, injected executors #4514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Generated by 🚫 Danger |
Contributor
Coverage Report 1Affected ProductsNo changes between base commit (fa8d364) and merge commit (82c97b3).Test Logs |
Contributor
Unit Test Results 143 files - 259 143 suites - 259 8m 3s ⏱️ - 1h 4m 30s Results for commit 1525eb2. ± Comparison against base commit 2c27445. ♻️ This comment has been updated with latest results. |
Contributor
Size Report 1Affected Products
Test Logs |
Contributor
Startup Time Report 1Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS. Notes
Startup Times
|
rlazo
reviewed
Jan 5, 2023
...installations/src/test/java/com/google/firebase/installations/FirebaseInstallationsTest.java
Outdated
Show resolved
Hide resolved
rlazo
reviewed
Jan 11, 2023
...installations/src/test/java/com/google/firebase/installations/FirebaseInstallationsTest.java
Outdated
Show resolved
Hide resolved
rlazo
approved these changes
Jan 11, 2023
mrober
pushed a commit
that referenced
this pull request
Jan 30, 2023
* Move Firebase Installations to the new, injected executors * added sequential executor as network executor to fix tests * re-organized libraries and test executor Co-authored-by: David Motsonashvili <[email protected]>
Member
|
@davidmotson Should this invoke a release? If so, could we add something to the changelog about it in a separate commit? |
davidmotson
pushed a commit
that referenced
this pull request
Feb 9, 2023
daymxn
added a commit
that referenced
this pull request
Feb 9, 2023
Co-authored-by: David Motsonashvili <[email protected]> Co-authored-by: Daymon <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.