Skip to content

test(functions): fix instrumentation tests #4249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2022
Merged

test(functions): fix instrumentation tests #4249

merged 2 commits into from
Oct 27, 2022

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Oct 26, 2022 •
edited
Loading

The firebase-functions instrumentation tests broke after updating the firebase-iid version in #4225 . This PR should fix them.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 26, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-functions

    Overall coverage changed from ? (d939e63) to 3.65% (7771c4d) by ?.

    11 individual files with coverage change

    FilenameBase (d939e63)Merge (7771c4d)Diff
    ContextProvider.java?0.00%?
    FirebaseContextProvider.java?0.00%?
    FirebaseFunctions.java?0.00%?
    FirebaseFunctionsException.java?0.00%?
    FunctionsMultiResourceComponent.java?0.00%?
    FunctionsRegistrar.java?66.67%?
    HttpsCallableContext.java?0.00%?
    HttpsCallableReference.java?0.00%?
    HttpsCallableResult.java?0.00%?
    HttpsCallOptions.java?0.00%?
    Serializer.java?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9bG28WnLsE.html

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2022 •
edited
Loading

Unit Test Results

6 tests  ±0   6 ✔️ ±0   17s ⏱️ -2s
3 suites ±0   0 💤 ±0 
3 files   ±0   0 ❌ ±0 

Results for commit f8309cd. ± Comparison against base commit d939e63.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 26, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (d939e63) and merge commit (7771c4d).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1BoH0O7frx.html

@thatfiredev thatfiredev requested a review from rlazo October 27, 2022 17:48
@rlazo rlazo merged commit 854cba5 into master Oct 27, 2022
@rlazo rlazo deleted the rpf-fix-functions-instrument-tests branch October 27, 2022 17:52
@firebase firebase locked and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees
No one assigned
Labels
no-changelog size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thatfiredev @google-oss-bot @rlazo