Skip to content

return exception if modelname is empty #4226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022
Merged

return exception if modelname is empty #4226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...main/java/com/google/firebase/ml/modeldownloader/internal/CustomModelDownloadService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import android.content.Context;
import android.content.pm.PackageManager;
import android.text.TextUtils;
import android.util.JsonReader;
import android.util.Log;
import androidx.annotation.NonNull;
Expand Down Expand Up @@ -148,6 +149,12 @@ public Task<CustomModel> getNewDownloadUrlWithExpiry(String projectNumber, Strin
public Task<CustomModel> getCustomModelDetails(
String projectNumber, String modelName, String modelHash) {
try {

if (TextUtils.isEmpty(modelName))
throw new FirebaseMlException(
"Error cannot retrieve model from reading an empty modelName",
FirebaseMlException.INVALID_ARGUMENT);

URL url =
new URL(String.format(DOWNLOAD_MODEL_REGEX, downloadHost, projectNumber, modelName));
HttpURLConnection connection = (HttpURLConnection) url.openConnection();
Expand Down Expand Up @@ -206,6 +213,8 @@ public Task<CustomModel> getCustomModelDetails(
new FirebaseMlException(
"Error reading custom model from download service: " + e.getMessage(),
FirebaseMlException.INVALID_ARGUMENT));
} catch (FirebaseMlException e) {
return Tasks.forException(e);
}
}

Expand Down