Skip to content

Assign ConfigContainer Builder return values. #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Assign ConfigContainer Builder return values. #4194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...config/src/main/java/com/google/firebase/remoteconfig/internal/ConfigFetchHttpClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ private static ConfigContainer extractConfigs(JSONObject fetchResponse, Date fet
// Do nothing if entries do not exist.
}
if (entries != null) {
containerBuilder.replaceConfigsWith(entries);
containerBuilder = containerBuilder.replaceConfigsWith(entries);
}

JSONArray experimentDescriptions = null;
Expand All @@ -423,7 +423,7 @@ private static ConfigContainer extractConfigs(JSONObject fetchResponse, Date fet
// Do nothing if entries do not exist.
}
if (experimentDescriptions != null) {
containerBuilder.withAbtExperiments(experimentDescriptions);
containerBuilder = containerBuilder.withAbtExperiments(experimentDescriptions);
}

JSONObject personalizationMetadata = null;
Expand All @@ -433,7 +433,7 @@ private static ConfigContainer extractConfigs(JSONObject fetchResponse, Date fet
// Do nothing if personalizationMetadata does not exist.
}
if (personalizationMetadata != null) {
containerBuilder.withPersonalizationMetadata(personalizationMetadata);
containerBuilder = containerBuilder.withPersonalizationMetadata(personalizationMetadata);
}

return containerBuilder.build();
Expand Down
4 changes: 2 additions & 2 deletions ...onfig/src/test/java/com/google/firebase/remoteconfig/internal/ConfigFetchHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,10 +1033,10 @@ private static ConfigContainer extractConfigs(JSONObject fetchResponse, Date fet
ConfigContainer.newBuilder().withFetchTime(fetchTime);

JSONObject entries = fetchResponse.getJSONObject(ENTRIES);
containerBuilder.replaceConfigsWith(entries);
containerBuilder = containerBuilder.replaceConfigsWith(entries);

JSONArray experimentDescriptions = fetchResponse.getJSONArray(EXPERIMENT_DESCRIPTIONS);
containerBuilder.withAbtExperiments(experimentDescriptions);
containerBuilder = containerBuilder.withAbtExperiments(experimentDescriptions);

return containerBuilder.build();
}
Expand Down