Skip to content

Make next collection group to update more deterministic #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Make next collection group to update more deterministic #3484

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
56077ee
Make next collection group to update more deterministic
wu-hui Feb 24, 2022
3aaa5e4
Format
wu-hui Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions firebase-firestore/src/main/java/com/google/firebase/firestore/local/SQLiteIndexManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,15 @@ final class SQLiteIndexManager implements IndexManager {
private final Queue<FieldIndex> nextIndexToUpdate =
new PriorityQueue<>(
10,
(l, r) ->
Long.compare(
l.getIndexState().getSequenceNumber(), r.getIndexState().getSequenceNumber()));
(l, r) -> {
int sequenceCmp =
Long.compare(
l.getIndexState().getSequenceNumber(), r.getIndexState().getSequenceNumber());
if (sequenceCmp == 0) {
return l.getCollectionGroup().compareTo(r.getCollectionGroup());
}
return sequenceCmp;
});

private boolean started = false;
private int memoizedMaxIndexId = -1;
Expand Down