Gracefully handling array-like arguments in sendAll()/sendMulticast() #569
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In newer JS specs like
es2015, custom array types can have a constructor that is notArray.ES5 output: true [Function: Array]
ES2015 output: true [Function: CustomArray]
Our
utils.deepCopy()method does not correctly copy such objects, which sometimes causes unusual behaviors. This fixes the issue for the FCM APIs affected by this problem.Ideally, we should push this fix down into the
deepCopy()method. But that would affect all the modules. I'd prefer to test this out with FCM first, and if all looks good move the fix todeepCopy()in the future.Resolves #566