Skip to content

Update SSRC to use validator instead of lodash for non-dev environment #2523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 9, 2024
Merged

Update SSRC to use validator instead of lodash for non-dev environment #2523

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02cc080
Add lodash as a runtime dep
erikeldridge Apr 5, 2024
a3fe81a
Move lodash to runtime deps
erikeldridge Apr 5, 2024
5ca953a
Regenerate package-lock for Node 14
erikeldridge Apr 5, 2024
79d91ce
Replace lodash.isString with validator.isString
erikeldridge Apr 9, 2024
5bb63c3
Merge remote-tracking branch 'gh-public/ssrc' into ssrc-lodash
erikeldridge Apr 9, 2024
179dc86
Revert lodash version increase
erikeldridge Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/remote-config/remote-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import {
InitServerTemplateOptions,
ServerTemplateDataType,
} from './remote-config-api';
import { isString } from 'lodash';

/**
* The Firebase `RemoteConfig` service interface.
Expand Down Expand Up @@ -205,6 +204,7 @@ export class RemoteConfig {
if (options?.template) {
template.set(options?.template);
}

return template;
}
}
Expand Down Expand Up @@ -328,7 +328,7 @@ class ServerTemplateImpl implements ServerTemplate {
*/
public set(template: ServerTemplateDataType): void {
let parsed;
if (isString(template)) {
if (validator.isString(template)) {
try {
parsed = JSON.parse(template);
} catch (e) {
Expand Down