Skip to content

fix: Removed App from the top-level admin namespace #1236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021
Merged

fix: Removed App from the top-level admin namespace #1236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions etc/firebase-admin.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,12 @@ import { FirebaseDatabase } from '@firebase/database-types';
import * as _firestore from '@google-cloud/firestore';
import * as rtdb from '@firebase/database-types';

// @public
export interface App {
name: string;
options: AppOptions;
}

// @public (undocumented)
export function app(name?: string): app.App;

// @public (undocumented)
export namespace app {
// Warning: (ae-forgotten-export) The symbol "App" needs to be exported by the entry point default-namespace.d.ts
export interface App extends App {
// (undocumented)
auth(): auth.Auth;
Expand Down
2 changes: 1 addition & 1 deletion src/firebase-namespace-api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import { storage } from './storage/storage-namespace';

import { App as AppCore, AppOptions } from './app/index';

export { App, AppOptions, FirebaseError, FirebaseArrayIndexError } from './app/index';
export { AppOptions, FirebaseError, FirebaseArrayIndexError } from './app/index';

// eslint-disable-next-line @typescript-eslint/no-namespace
export namespace app {
Expand Down