Reading FCM error code from the details section #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avishalom
reviewed
Mar 30, 2018
| } | ||
|
|
||
| @Test | ||
| public void testNullMessage() throws Exception { |
Contributor
There was a problem hiding this comment.
did you remove the throws on purpose? (I'm good either way, but the next test has it)
Contributor
Author
There was a problem hiding this comment.
Yes, the compiler flagged this as redundant. Other tests call methods that throw checked exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting error handling improvement from firebase/firebase-admin-node#246
Reading error code from the
detailssection of the HTTP response when available.