Handling some WebSocket connection errors gracefully #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
suggested changes
Mar 26, 2018
| logger.debug("WebSocket reached EOF", e); | ||
| } else { | ||
| logger.error("WebSocket error", e); | ||
| logger.debug("WebSocket error", e); |
Contributor
There was a problem hiding this comment.
Do you think it might make sense to still log all other errors at 'error' level? You should really only suppress the IllegalStateException you created in NettyWebsocketClient.
schmidt-sebastian
approved these changes
Mar 26, 2018
| if (e.getCause() != null && e.getCause() instanceof EOFException) { | ||
| logger.error("WebSocket reached EOF", e); | ||
| if (e instanceof EOFException | ||
| || (e.getCause() != null && e.getCause() instanceof EOFException)) { |
Contributor
There was a problem hiding this comment.
You don't need to perform a null check before calling instanceof.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a small delay between
channelInactive()low-level event, and us callingchannel.close(). The former executes on a Netty worker thread, while the latter is on the runloop. An outgoingsend()may sneak through this window to cause a hard assertion failure.The old tubesock implementation handled this type of race conditions more gracefully, by simply logging the error and closing the connection for good. This PR essentially implements the same semantics on top of Netty.
b/74831164