Accept prefixed topic names #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.webpushConfig = builder.webpushConfig; | ||
| this.apnsConfig = builder.apnsConfig; | ||
|
|
||
| String unprefixedTopic = null; |
Contributor
There was a problem hiding this comment.
Can you move this to a helper function and call this stripPrefix()? I think the name unprefixedTopic will never win my heart over :)
schmidt-sebastian
approved these changes
Feb 7, 2018
hiranya911
added a commit
that referenced
this pull request
Feb 13, 2018
* Adding experimental FCM API * Added Webpush notification support * Added APNS support and tests * Added subscribe method * Added TopicManagementResponse type * Added unsub method * Improved error handling and json parsing * More tests, validation and dry run mode * Improved error handling and tests * Added license header; Implemented topic name normalization * Improved error handling * Improved error handling * Added javadocs * Fixing auth (ADC) test failure * Updated documentation * Updated documentation * Updated javadocs * Updated test * Renamed Priority enum values (using uppercase) * Adding APNS types * Updated APNS documentation * Updated integration test * Making TTL a long argument * Updated changelog * Addressing a number of readability nits, and other code review comments * Fixing some nits * Removing some duplicate code in messaging tests * Further deduping code in test * Accept prefixed topic names (#136) * Accept prefixed topic names * Parsing topic name in a helper method * Updated javadoc for setTopic() * Updated FCM error codes (#138) * Merged with dev; updated changelog * Updated changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new FCM API does not accept topic names prefixed with
/topics/. But we can easily check for this in the SDK and remove it. This results in a better and consistent dev experience since the other methods in this API accepts prefixed topic names.