Skip to content

Support dark mode in auth flow #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 25, 2019
Merged

Support dark mode in auth flow #762

merged 3 commits into from
Sep 25, 2019

Conversation

cbess
Copy link
Contributor

@cbess cbess commented Aug 28, 2019

Resolves #723 for the Swift code authentication flow.

cbess added 3 commits August 28, 2019 13:10
@cbess
Update FUIPrivacyAndTermsOfServiceView.m
affdec5 
use system label color
@cbess
Merge branch 'master' of github.com:firebase/FirebaseUI-iOS into auth…
4c4733c 
…-ui-update
@cbess
Update tables to use dark theme
5245b7c 
- Set auth cell fields to system color
- Update Swift-flow main storyboard to use system colors
morganchen12
morganchen12 approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does Xcode 10.x support the new key/values in the sample storyboard file?

@cbess
Copy link
Contributor Author

cbess commented Aug 28, 2019

I'll check and let ya know

@cbess
Copy link
Contributor Author

cbess commented Aug 28, 2019 •
edited
Loading

LGTM. Does Xcode 10.x support the new key/values in the sample storyboard file?

So, it opens with no problem. But, some of the constraints and such render oddly. Also, it won't build due to the [UIColor labelColor] use. Essentially, due to the iOS 13 SDK not being available in Xcode 10. Thoughts?

@cbess
Copy link
Contributor Author

cbess commented Aug 28, 2019

I suppose I could use #ifdef __IPHONE_13_0

@morganchen12
Copy link
Contributor

No, no need to update the code. Let's keep this PR open until we update Xcode on Travis to support building the new IB file.

@melsam
Copy link

melsam commented Sep 23, 2019

Is there an ETA to get this merged? Now that iOS 13 has officially launched, not having this is preventing our app from fully supporting dark mode.

@cbess
Copy link
Contributor Author

cbess commented Sep 23, 2019

@morganchen12 I'm also curious about when it will be merged, now that Xcode 11 is generally available via the Mac App Store.

@morganchen12
Copy link
Contributor

I plan on merging this week. Bumping the dependency in Travis should take less than a day.

@cbess cbess mentioned this pull request Sep 24, 2019
Closed
@morganchen12 morganchen12 merged commit e0a6e13 into firebase:master Sep 25, 2019
@morganchen12
Copy link
Contributor

Thanks @cbess for contributing!

@cbess cbess deleted the auth-ui-update branch March 25, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dark mode

4 participants

@cbess @morganchen12 @melsam @googlebot