Addressing issue #464 #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always displaying the displayName isn't a option as a custom field (_requireDisplayName) has been created specificially for this - The email address on the signin and signup controllers have been disabled from editing for the following reason: the email address is being verified in the previous screen and allowing the user to edit it at this point bypass all the previous validations (so the user can potentially signup with an existing email address for example)
|
Looks good to me. Thanks! |
b-yng
added a commit
to b-yng/FirebaseUI-iOS
that referenced
this pull request
Nov 6, 2019
* master: (100 commits) Fix default value not being passed when allowNewEmailAccounts was disabled Privacy and Terms of Service links did not react on touches. Fix deprecation warning Separate interactive dismissal and cancel button customization Prevents arab users from entering Arabic digits to verification code. Prevent interactive dismiss when cancel button is hidden Better key type. Authentication with e-mail link was not working in iOS13. The success alert got removed right away, without notifying the delegate. Bump travis version Auto-update dependencies. bump podspec version Auto-update dependencies. Auto-update dependencies. Auto-update dependencies. Auto-update dependencies. Update tables to use dark theme Update FUIPrivacyAndTermsOfServiceView.m Auto-update dependencies. Auto-update dependencies. Addressing issue firebase#464 (firebase#757) ...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding the comments from the original ticket (#464) :
displayName fieldhasn't been implemented as a custom field_requireDisplayNamehas been created specifically for this and should be used by the developer.Let me know if that makes sense or if you'd like to see any other change applied and I'll update the PR