Skip to content

fix: Stop error modal popup on MFA resolution #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2025
Merged

fix: Stop error modal popup on MFA resolution #1289

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e17ee4d
fix: do not show error modal when MFA required
russellwheatley Oct 29, 2025
4a517a2
Merge branch 'development' into stop-error-modal-on-mfa-resolution
russellwheatley Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions FirebaseSwiftUI/FirebaseAuthSwiftUI/Sources/Services/AuthService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,8 +232,6 @@ public final class AuthService {
}
} catch let error as NSError {
authenticationState = .unauthenticated
updateError(message: string.localizedErrorMessage(for: error))

// Check if this is an MFA required error
if error.code == AuthErrorCode.secondFactorRequired.rawValue {
if let resolver = error
Expand All @@ -242,6 +240,9 @@ public final class AuthService {
pendingMFACredential = credentials
return handleMFARequiredError(resolver: resolver)
}
} else {
// Don't want error modal on MFA error so we only update here
updateError(message: string.localizedErrorMessage(for: error))
}

throw error
Expand Down
Loading