Skip to content

fix: ensure Facebook limited or classic login occurs when selected #1282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2025
+4 −3
Merged

fix: ensure Facebook limited or classic login occurs when selected #1282

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4b146a
fix: ensure Facebook limited or classic login occurs when selected
russellwheatley Oct 27, 2025
154e38f
Merge branch 'development' into fix-limited-login
russellwheatley Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FirebaseSwiftUI/FirebaseFacebookSwiftUI/Sources/Services/FacebookProviderAuthUI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,6 @@ public class FacebookProviderAuthUI: AuthProviderUI {
}

@MainActor public func authButton() -> AnyView {
AnyView(SignInWithFacebookButton(facebookProvider: provider))
AnyView(SignInWithFacebookButton(facebookProvider: provider as! FacebookProviderSwift))
}
}
5 changes: 3 additions & 2 deletions FirebaseSwiftUI/FirebaseFacebookSwiftUI/Sources/Views/SignInWithFacebookButton.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,14 @@ import SwiftUI
@MainActor
public struct SignInWithFacebookButton {
@Environment(AuthService.self) private var authService
let facebookProvider: AuthProviderSwift
let facebookProvider: FacebookProviderSwift
@State private var showCanceledAlert = false
@State private var limitedLogin = true
@State private var showUserTrackingAlert = false
@State private var trackingAuthorizationStatus: ATTrackingManager
.AuthorizationStatus = .notDetermined

public init(facebookProvider: AuthProviderSwift) {
public init(facebookProvider: FacebookProviderSwift) {
self.facebookProvider = facebookProvider
_trackingAuthorizationStatus = State(initialValue: ATTrackingManager
.trackingAuthorizationStatus)
Expand Down Expand Up @@ -66,6 +66,7 @@ extension SignInWithFacebookButton: View {
VStack {
Button(action: {
Task {
facebookProvider.isLimitedLogin = limitedLogin
try? await authService.signIn(facebookProvider)
}
}) {
Expand Down
Loading