Skip to content

Crash fixed + repo Package made buildable again #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Crash fixed + repo Package made buildable again #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d567de4
fixed crash on logout button press - UI cade was called from backgrou…
ihar-shalouski Aug 31, 2025
cabb7ff
added iOS type conditions for repo to keep on building for iOS 11
ihar-shalouski Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Filestack/Internal/Requests/LogoutRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ final class LogoutRequest {
let task = URLSession.filestackDefault.dataTask(with: request) { (data, response, error) in
let response = LogoutResponse(error: error)

completionBlock(response)
DispatchQueue.main.async { completionBlock(response) }
}

task.resume()
Expand Down
4 changes: 3 additions & 1 deletion Sources/Filestack/Public/Models/Client.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,9 @@ private extension Client {
}

// Set the presentation context provider
session.presentationContextProvider = self
if #available(iOS 13.0, *) {
session.presentationContextProvider = self
}

// Keep a strong reference to the auth session.
self.safariAuthSession = session
Expand Down
22 changes: 15 additions & 7 deletions Sources/Filestack/UI/Internal/Controllers/DocumentPickerUploadController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,22 @@ class DocumentPickerUploadController: URLPickerUploadController {
viewController: UIViewController,
config: Config,
completionBlock: (([URL]) -> Void)? = nil) {
let allowedContentTypes = config.documentPickerAllowedUTIs.compactMap { UTIString in
if let contentType = UTType(UTIString) {
return contentType
} else {
return nil
}
if #available(iOS 14.0, *) {
let allowedContentTypes: [UTType] = config.documentPickerAllowedUTIs
.compactMap { UTType($0) }
self.picker = UIDocumentPickerViewController(
forOpeningContentTypes: allowedContentTypes.isEmpty ? [UTType.item] : allowedContentTypes,
asCopy: true
)
} else {
let docTypes: [String] = config.documentPickerAllowedUTIs.isEmpty
? ["public.item"]
: config.documentPickerAllowedUTIs
self.picker = UIDocumentPickerViewController(
documentTypes: docTypes,
in: .import
)
}
self.picker = UIDocumentPickerViewController(forOpeningContentTypes: allowedContentTypes.isEmpty ? [.item] : allowedContentTypes, asCopy: true)
super.init(uploader: uploader,
viewController: viewController,
presentedViewController: picker,
Expand Down
8 changes: 7 additions & 1 deletion Sources/Filestack/UI/Internal/PhotoPicker/AlbumList/AlbumListViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,13 @@ private extension AlbumListViewController {
private extension AlbumListViewController {
func createAndStartLaodingView() {
DispatchQueue.main.async {
let indicator = UIActivityIndicatorView(style: .medium)
let style: UIActivityIndicatorView.Style
if #available(iOS 13.0, *) {
style = .medium
} else {
style = .gray
}
let indicator = UIActivityIndicatorView(style: style)
indicator.center = self.view.center
indicator.startAnimating()
self.view.addSubview(indicator)
Expand Down