Skip to content

Conversation

@hez2010
Copy link
Member

@hez2010 hez2010 commented Oct 16, 2021

Resolved / Related Issues
Items resolved / related issues by this PR.

Details of Changes
Add details of changes here.

  • Added InfoBadge to status center

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

@yaira2 yaira2 requested a review from winston-de October 17, 2021 00:34
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Oct 17, 2021
Copy link
Contributor

@winston-de winston-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Oct 18, 2021
@yaira2
Copy link
Member

yaira2 commented Oct 18, 2021

@hez2010 can you test to make sure these changes work with the screenreader?

@hez2010
Copy link
Member Author

hez2010 commented Oct 19, 2021

What are the expectations?
Though I don't think this would change the behavior of screenreader, it only added a badge on the right-top corner of the status center button.

@yaira2
Copy link
Member

yaira2 commented Oct 19, 2021

What are the expectations? Though I don't think this would change the behavior of screenreader, it only added a badge on the right-top corner of the status center button.

@hez2010 does the screen reader read the number in the badge?

@yaira2 yaira2 merged commit d04ff9e into files-community:main Oct 20, 2021
@hez2010
Copy link
Member Author

hez2010 commented Oct 20, 2021

Sorry for haven't yet got a proper time to test the screen reader. Does screen reader work as expected?

@yaira2
Copy link
Member

yaira2 commented Oct 20, 2021

Sorry for haven't yet got a proper time to test the screen reader. Does screen reader work as expected?

It doesn't seem like I can focus on the InfoBadge but I was thinking that the relevant info should really be added to the automation properties of the status center button rather than allowing the user to focus on the info badge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use InfoBadge for indicating remaining works on status center icon

3 participants