Skip to content

Conversation

0x5bfa
Copy link
Member

@0x5bfa 0x5bfa commented Jul 21, 2024

Resolved / Related Issues

Panned internally

Steps used to test these changes

  1. Open Files app
  2. Resize to be minimum (see if min size info is set)
  3. Terminate the app
  4. Lunch the app again (see if the last window placement is kept)
  5. Open properties window of a file (see if you can resize but can't maximize)
  6. See caption buttons of both windows have the correct brush now and even after you switch theme
  7. Enable 'Automatically hide taskbar' in Windows settings
  8. Enter F11 on the app
  9. Try to hover over on the bottom of the monitor (see taskbar fades in)

@Jay-o-Way
Copy link
Contributor

@niels9001 something to think about for PowerToys maybe?

@yaira2
Copy link
Member

yaira2 commented Jul 21, 2024

We have been very satisfied with WinUIEx, as it provided a crucial function during our initial migration to WinAppSdk. However, given the improvements in WinAppSdk, we have reached a point where this dependency is no longer necessary.

@yaira2 yaira2 force-pushed the 5bfa/CQ-WinUIExRemoval branch from 0ba54d2 to e7136c1 Compare July 22, 2024 16:44
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-WinUIExRemoval branch 3 times, most recently from b9627c5 to c756aca Compare July 23, 2024 09:38
@yaira2 yaira2 marked this pull request as ready for review July 30, 2024 15:24
@yaira2
Copy link
Member

yaira2 commented Jul 30, 2024

@0x5bfa can you resolve the merge conflicts?

@yaira2 yaira2 changed the title Code Qaulity: Remove WinUIEx dependency Code Quality: Remove WinUIEx dependency Aug 4, 2024
@yaira2
Copy link
Member

yaira2 commented Aug 4, 2024

@0x5bfa launching Files via this branch doesn't seem to work.

@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-WinUIExRemoval branch 2 times, most recently from 7203d04 to e0874eb Compare August 8, 2024 14:06
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-WinUIExRemoval branch from 3d41b38 to 799527c Compare August 8, 2024 14:11
@0x5bfa 0x5bfa force-pushed the 5bfa/CQ-WinUIExRemoval branch from 622ebcd to 74725da Compare August 8, 2024 15:59
@0x5bfa
Copy link
Member Author

0x5bfa commented Aug 10, 2024

Ready for testing.

@yaira2
Copy link
Member

yaira2 commented Aug 11, 2024

@0x5bfa I’ve noticed that when I’m in full screen mode, the taskbar doesn’t show up when I move the cursor to the taskbar area. Everything else appears to be working though!

@0x5bfa
Copy link
Member Author

0x5bfa commented Aug 13, 2024

Fixed

@yaira2 yaira2 requested a review from hez2010 August 14, 2024 17:22
@yaira2 yaira2 changed the title Code Quality: Remove WinUIEx dependency Code Quality: Removed WinUIEx dependency Aug 14, 2024
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Aug 14, 2024
@yaira2 yaira2 merged commit 8d93a57 into files-community:main Aug 15, 2024
6 checks passed
@0x5bfa 0x5bfa deleted the 5bfa/CQ-WinUIExRemoval branch August 15, 2024 15:08
@yaira2
Copy link
Member

yaira2 commented Aug 19, 2024

@0x5bfa I found an issue where the navigation items are missing from the properties window.

@0x5bfa
Copy link
Member Author

0x5bfa commented Aug 19, 2024

What do you mean??
It gone? On my machine, it exists

@yaira2
Copy link
Member

yaira2 commented Aug 19, 2024

Did you compile from main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: remove WinuiEx dependency (when possible)
3 participants