Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Conversation

@Seb-figment
Copy link

No description provided.

@Seb-figment Seb-figment marked this pull request as ready for review June 30, 2022 17:16
@pienkowb
Copy link

pienkowb commented Jul 1, 2022

Is this the same as this example (except it's using the cosmoshub-ts package)?

@Seb-figment
Copy link
Author

Is this the same as this example (except it's using the cosmoshub-ts package)?

Base on it yes. In addition to using the cosmoshub-ts package it only process /cosmos.staking.v1beta1.MsgDelegate message.

@pienkowb
Copy link

pienkowb commented Jul 6, 2022

Base on it yes. In addition to using the cosmoshub-ts package it only process /cosmos.staking.v1beta1.MsgDelegate message.

@Seb-figment To me, these examples are pretty much the same. Let's just update the example we already have (validator-delegations) so that the decoding function is imported from the cosmoshub-ts package instead of a file.

@Seb-figment
Copy link
Author

I approach that example as a way to show difference when using messageHandler vs transactionHandler. If we update validator-delegations we wont have an example for transactionHandler

@pienkowb
Copy link

pienkowb commented Jul 6, 2022

If we update validator-delegations we wont have an example for transactionHandler

I think that's fine. Since we introduced the message handler, the usefulness of the transaction handler is rather low.

These examples should be focused around use cases, not necessarily on the handlers themselves.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants