Skip to content

Avoid augmenting subarrays post-ES2016 #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid augmenting subarrays post-ES2016 #351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,6 +1117,8 @@ function utf16leSlice (buf, start, end) {
return res
}

let subarrayCallsChild = false

Buffer.prototype.slice = function slice (start, end) {
const len = this.length
start = ~~start
Expand All @@ -1139,8 +1141,11 @@ Buffer.prototype.slice = function slice (start, end) {
if (end < start) end = start

const newBuf = this.subarray(start, end)
// Return an augmented `Uint8Array` instance
Object.setPrototypeOf(newBuf, Buffer.prototype)

if (!subarrayCallsChild) {
// Return an augmented `Uint8Array` instance
Object.setPrototypeOf(newBuf, Buffer.prototype)
}

return newBuf
}
Expand Down Expand Up @@ -2152,3 +2157,7 @@ function defineBigIntMethod (fn) {
function BufferBigIntNotDefined () {
throw new Error('BigInt not supported')
}

if (Buffer.TYPED_ARRAY_SUPPORT) {
subarrayCallsChild = createBuffer(1).subarray(0, 1) instanceof Buffer
}