Skip to content

Add format_version #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2017
Merged

Add format_version #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions s3.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ type S3 struct {
Period uint `mapstructure:"period"`
GzipLevel uint `mapstructure:"gzip_level"`
Format string `mapstructure:"format"`
FormatVersion uint `mapstructure:"format_version"`
ResponseCondition string `mapstructure:"response_condition"`
TimestampFormat string `mapstructure:"timestamp_format"`
Redundancy S3Redundancy `mapstructure:"redundancy"`
Expand Down Expand Up @@ -94,6 +95,7 @@ type CreateS3Input struct {
Period uint `form:"period,omitempty"`
GzipLevel uint `form:"gzip_level,omitempty"`
Format string `form:"format,omitempty"`
FormatVersion uint `form:"format_version,omitempty"`
ResponseCondition string `form:"response_condition,omitempty"`
TimestampFormat string `form:"timestamp_format,omitempty"`
Redundancy S3Redundancy `form:"redundancy,omitempty"`
Expand Down Expand Up @@ -179,6 +181,7 @@ type UpdateS3Input struct {
Period uint `form:"period,omitempty"`
GzipLevel uint `form:"gzip_level,omitempty"`
Format string `form:"format,omitempty"`
FormatVersion uint `form:"format_version,omitempty"`
ResponseCondition string `form:"response_condition,omitempty"`
TimestampFormat string `form:"timestamp_format,omitempty"`
Redundancy S3Redundancy `form:"redundancy,omitempty"`
Expand Down
7 changes: 7 additions & 0 deletions s3_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ func TestClient_S3s(t *testing.T) {
Period: 12,
GzipLevel: 9,
Format: "format",
FormatVersion: 2,
TimestampFormat: "%Y",
Redundancy: S3RedundancyReduced,
})
Expand Down Expand Up @@ -78,6 +79,9 @@ func TestClient_S3s(t *testing.T) {
if s3.Format != "format" {
t.Errorf("bad format: %q", s3.Format)
}
if s3.FormatVersion != 2 {
t.Errorf("bad format_version: %q", s3.FormatVersion)
}
if s3.TimestampFormat != "%Y" {
t.Errorf("bad timestamp_format: %q", s3.TimestampFormat)
}
Expand Down Expand Up @@ -139,6 +143,9 @@ func TestClient_S3s(t *testing.T) {
if s3.Format != ns3.Format {
t.Errorf("bad format: %q", s3.Format)
}
if s3.FormatVersion != ns3.FormatVersion {
t.Errorf("bad format_version: %q", s3.FormatVersion)
}
if s3.TimestampFormat != ns3.TimestampFormat {
t.Errorf("bad timestamp_format: %q", s3.TimestampFormat)
}
Expand Down