Skip to content

types: added missing iso time types #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2025

Conversation

gulbaki
Copy link
Contributor

@gulbaki gulbaki commented Jun 18, 2025

Adding missing TypeScript support for iso-time and iso-date-time formats
Adding documentation for both formats in the API reference
Providing dedicated unit and TypeScript test coverage
fixes: #267

Checklist

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Fdawgs Fdawgs changed the title Fix/iso time types tests types: added missing iso time types Aug 14, 2025
@Fdawgs Fdawgs requested a review from Copilot August 14, 2025 18:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds TypeScript support for two missing ISO format types (iso-time and iso-date-time) to the FluentJSONSchema library. This addresses issue #267 by implementing complete TypeScript definitions and test coverage for these ISO datetime formats.

  • Added TypeScript type definitions for iso-time and iso-date-time string formats
  • Extended test coverage with unit tests and TypeScript validation tests
  • Updated API documentation to include the new ISO format types

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
types/FluentJSONSchema.test-d.ts Adds TypeScript test case validating the new ISO format types
src/StringSchema.test.js Adds unit test for the ISO_TIME format validation
docs/API.md Updates documentation to include ISO_TIME and ISO_DATE_TIME formats

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@Fdawgs
Copy link
Member

Fdawgs commented Aug 14, 2025

Related to #254

@Fdawgs Fdawgs requested a review from a team August 14, 2025 18:12
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Fdawgs Fdawgs merged commit 819b9c2 into fastify:main Aug 14, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "must match format 'time'" after upgrading to fastify v5
4 participants