-
-
Notifications
You must be signed in to change notification settings - Fork 59
types: added missing iso time types #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds TypeScript support for two missing ISO format types (iso-time
and iso-date-time
) to the FluentJSONSchema library. This addresses issue #267 by implementing complete TypeScript definitions and test coverage for these ISO datetime formats.
- Added TypeScript type definitions for
iso-time
andiso-date-time
string formats - Extended test coverage with unit tests and TypeScript validation tests
- Updated API documentation to include the new ISO format types
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
types/FluentJSONSchema.test-d.ts | Adds TypeScript test case validating the new ISO format types |
src/StringSchema.test.js | Adds unit test for the ISO_TIME format validation |
docs/API.md | Updates documentation to include ISO_TIME and ISO_DATE_TIME formats |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Related to #254 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Adding missing TypeScript support for iso-time and iso-date-time formats
Adding documentation for both formats in the API reference
Providing dedicated unit and TypeScript test coverage
fixes: #267
Checklist
npm run test
andnpm run benchmark
and the Code of conduct