fix: issue #16 #17
Merged
fix: issue #16 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climba03003
requested changes
Jul 13, 2023
snippets/snippets-ts.json
Outdated
| "scope": "javascript,typescript", | ||
| "prefix": "ffhello", | ||
| "body": [ | ||
| "const app = require('fastify')({ logger: true })", |
There was a problem hiding this comment.
You should use import here.
snippets/snippets-ts.json
Outdated
| {} | ||
| { | ||
| "fastify hello server": { | ||
| "scope": "javascript,typescript", |
There was a problem hiding this comment.
The scope should be TypeScript only.
Signed-off-by: Aryan Singh <[email protected]>
|
@climba03003 I have made the required changes. |
climba03003
approved these changes
Jul 14, 2023
Eomm
reviewed
Jul 19, 2023
snippets/snippets-ts.json
Outdated
| "description": "Create an hello world server" | ||
| }, | ||
| "fastify register": { | ||
| "scope": "javascript,typescript", |
There was a problem hiding this comment.
We should fix all the scopes in the file
|
@Eomm I have made changes for the scopes, can you please review. |
Eomm
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct