Skip to content

Conversation

@Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Mar 8, 2021

Stop Yarn from sneaking in files

Checklist

Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it apply to other repo as well ?

@mcollina mcollina merged commit 6a6d6db into fastify:master Mar 8, 2021
@Fdawgs
Copy link
Member Author

Fdawgs commented Mar 8, 2021

Should it apply to other repo as well ?

You've lost me there @climba03003, what do you mean?

@Fdawgs Fdawgs deleted the chore/gitignore branch March 8, 2021 17:19
@climba03003
Copy link
Member

climba03003 commented Mar 8, 2021

Should it apply to other repo as well ?

You've lost me there @climba03003, what do you mean?

@Fdawgs Should other repo also need to update the .gitignore files like this one?
I think it is a very big duty to update all of them.

@Fdawgs
Copy link
Member Author

Fdawgs commented Mar 8, 2021

Should it apply to other repo as well ?

You've lost me there @climba03003, what do you mean?

@Fdawgs Should other repo also need to update the .gitignore files like this one?
I think it is a very big duty to update all of them.

Ah yeah, it is a big job!
I'm happy to do them though, as I plan on reviewing all of the core Fastify plugins and pretty much doing housekeeping tasks like updating the .gitignore files and docs.

As long as people like yourself and @mcollina are happy to review the changes then I'll keep going!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants