Skip to content

Conversation

@cemremengu
Copy link
Contributor

Added check for duplicate connection names

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a unit test?

@cemremengu
Copy link
Contributor Author

Apologies for the noise here, good to go.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina mcollina merged commit 5a7a3dd into fastify:master Sep 5, 2018
@cemremengu cemremengu deleted the patch-1 branch September 5, 2018 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants